From 100514d8c7fdfea17de938cddc63f1457dd3af3a Mon Sep 17 00:00:00 2001 From: Lean Sheng Tan Date: Wed, 18 May 2022 17:35:31 +0200 Subject: soc/intel/ehl: Fix logical bug for PseTsnGbePhyInterfaceType By right if PseTsnGbeSgmiiEnable is disable, PseTsnGbePhyInterfaceType should use RGMII setting. Signed-off-by: Lean Sheng Tan Change-Id: If593a5534716a9e93f99cb155fb5e86e12b1df17 Reviewed-on: https://review.coreboot.org/c/coreboot/+/64477 Tested-by: build bot (Jenkins) Reviewed-by: Mario Scheithauer --- src/soc/intel/elkhartlake/fsp_params.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/soc') diff --git a/src/soc/intel/elkhartlake/fsp_params.c b/src/soc/intel/elkhartlake/fsp_params.c index 2100cc4ded..aacb1e6f85 100644 --- a/src/soc/intel/elkhartlake/fsp_params.c +++ b/src/soc/intel/elkhartlake/fsp_params.c @@ -134,7 +134,7 @@ static void fill_fsps_tsn_params(FSP_S_CONFIG *params, params->PseTsnGbeMultiVcEnable[i] = config->PseTsnGbeMultiVcEnable[i]; params->PseTsnGbeSgmiiEnable[i] = config->PseTsnGbeSgmiiEnable[i]; params->PseTsnGbePhyInterfaceType[i] = - !!config->PseTsnGbeSgmiiEnable[i] ? + !config->PseTsnGbeSgmiiEnable[i] ? RGMII : config->PseTsnGbePhyType[i]; params->PseTsnGbeLinkSpeed[i] = (params->PseTsnGbePhyInterfaceType[i] < SGMII_plus) ? -- cgit v1.2.3