From 03784fa97a764be81ca9bcf79222e7b37e2e7692 Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Mon, 9 Dec 2013 17:46:22 -0800 Subject: Add check_member macro to allow clean and easy struct offset checking This patch adds a new static assertion macro that can be used to check the offsets in structures that overlay register sets at compile time. It uses the _Static_assert() declaration from the new ISO C11 standard, which is supported (even without -std=c11) by GCC after version 4.6. (There is supposedly also support in clang, although I haven't tried it... let's deal with compiler issues when/if they turn up.) I've added it to all structures for our current ARM SoCs for now, and I think every new register overlay we add going forward should use them (at least for the last member, but feel free to add more if you think it's useful). Change-Id: If32510e7049739ad05618d363a854dc372d64386 Signed-off-by: Julius Werner Reviewed-on: https://chromium-review.googlesource.com/179412 Reviewed-by: David Hendricks Reviewed-by: Stefan Reinauer (cherry picked from commit cef5fa13c31375a316ca4556c0039b17c8ea7900) Signed-off-by: Isaac Christensen Reviewed-on: http://review.coreboot.org/6905 Tested-by: build bot (Jenkins) --- src/soc/samsung/exynos5420/fimd.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/soc/samsung/exynos5420/fimd.h') diff --git a/src/soc/samsung/exynos5420/fimd.h b/src/soc/samsung/exynos5420/fimd.h index ce8773fd17..41e5ccd827 100644 --- a/src/soc/samsung/exynos5420/fimd.h +++ b/src/soc/samsung/exynos5420/fimd.h @@ -61,6 +61,7 @@ struct exynos5_fimd { u8 res9[0x18]; u32 dpclkcon; }; +check_member(exynos5_fimd, dpclkcon, 0x27c); #define W0_SHADOW_PROTECT (0x1 << 10) #define COMPKEY_F 0xffffff @@ -107,6 +108,7 @@ struct exynos5_disp_ctrl { u8 res2[0x184]; u32 trigcon; }; +check_member(exynos5_disp_ctrl, trigcon, 0x1a4); #define VCLK_RISING_EDGE (1 << 7) #define VCLK_RUNNING (1 << 9) -- cgit v1.2.3