From abefcc2e2c68f94414f85e18d35b624186ddd12f Mon Sep 17 00:00:00 2001
From: Moritz Fischer <moritzf@google.com>
Date: Sun, 28 Feb 2021 18:30:11 -0800
Subject: soc/rockchip/rk3399/sdram: Add channel to error message
When printing error information during DRAM training, be more verbose
by printing the channel number.
Change-Id: If4109bd0573e3d9f90d699d89350ddbcc48714d3
Signed-off-by: Moritz Fischer <moritzf@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51127
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Julius Werner <jwerner@chromium.org>
---
src/soc/rockchip/rk3399/sdram.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
(limited to 'src/soc/rockchip')
diff --git a/src/soc/rockchip/rk3399/sdram.c b/src/soc/rockchip/rk3399/sdram.c
index 6d58b6a171..be1da598a8 100644
--- a/src/soc/rockchip/rk3399/sdram.c
+++ b/src/soc/rockchip/rk3399/sdram.c
@@ -939,7 +939,7 @@ static int data_training(u32 channel, const struct rk3399_sdram_params *params,
if ((training_flag & PI_CA_TRAINING) == PI_CA_TRAINING) {
ret = data_training_ca(channel, params);
if (ret) {
- printk(BIOS_ERR, "CA training failed\n");
+ printk(BIOS_ERR, "Channel %d CA training failed\n", channel);
return ret;
}
}
@@ -948,7 +948,7 @@ static int data_training(u32 channel, const struct rk3399_sdram_params *params,
if ((training_flag & PI_WRITE_LEVELING) == PI_WRITE_LEVELING) {
ret = data_training_wl(channel, params);
if (ret) {
- printk(BIOS_ERR, "WL training failed\n");
+ printk(BIOS_ERR, "Channel %d WL training failed\n", channel);
return ret;
}
}
@@ -957,7 +957,7 @@ static int data_training(u32 channel, const struct rk3399_sdram_params *params,
if ((training_flag & PI_READ_GATE_TRAINING) == PI_READ_GATE_TRAINING) {
ret = data_training_rg(channel, params);
if (ret) {
- printk(BIOS_ERR, "RG training failed\n");
+ printk(BIOS_ERR, "Channel %d RG training failed\n", channel);
return ret;
}
}
@@ -966,7 +966,7 @@ static int data_training(u32 channel, const struct rk3399_sdram_params *params,
if ((training_flag & PI_READ_LEVELING) == PI_READ_LEVELING) {
ret = data_training_rl(channel, params);
if (ret) {
- printk(BIOS_ERR, "RL training failed\n");
+ printk(BIOS_ERR, "Channel %d RL training failed\n", channel);
return ret;
}
}
@@ -975,7 +975,7 @@ static int data_training(u32 channel, const struct rk3399_sdram_params *params,
if ((training_flag & PI_WDQ_LEVELING) == PI_WDQ_LEVELING) {
ret = data_training_wdql(channel, params);
if (ret) {
- printk(BIOS_ERR, "WDQL training failed\n");
+ printk(BIOS_ERR, "Channel %d WDQL training failed\n", channel);
return ret;
}
}
--
cgit v1.2.3