From 9a1bb36137921c751173d6726a06019c84b171f5 Mon Sep 17 00:00:00 2001 From: Aaron Durbin Date: Thu, 19 Apr 2018 16:58:13 -0600 Subject: soc{broadcom,imgtec,mediatek,qualcomm}: stop using spi_xfer_two_vectors On a second look broadcom/cygnus and imgtec/pistachio appear to support full duplex. Therefore, remove the use of spi_xfer_two_vectors(). For mediatek/mt8173 and qualcomm/ipq40xx, the driver is written in such a way that it does not support full duplex. Remove the use of spi_xfer_two_vectors() and explicitly error out when a full duplex transaction is requested. Change-Id: I8689bc9bb2b27563d25e9f165487d38881c0b059 Signed-off-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/25742 Reviewed-by: Furquan Shaikh Reviewed-by: Paul Menzel Tested-by: build bot (Jenkins) --- src/soc/qualcomm/ipq40xx/spi.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/soc/qualcomm/ipq40xx/spi.c') diff --git a/src/soc/qualcomm/ipq40xx/spi.c b/src/soc/qualcomm/ipq40xx/spi.c index 3dc6022b03..4498b31183 100644 --- a/src/soc/qualcomm/ipq40xx/spi.c +++ b/src/soc/qualcomm/ipq40xx/spi.c @@ -611,6 +611,10 @@ static int spi_ctrlr_xfer(const struct spi_slave *slave, const void *dout, u8 *rxp = (u8 *)din; int ret; + /* Driver implementation does not support full duplex. */ + if (dout && din) + return -1; + ret = config_spi_state(ds, QUP_STATE_RESET); if (ret != SUCCESS) return ret; @@ -687,7 +691,6 @@ static const struct spi_ctrlr spi_ctrlr = { .claim_bus = spi_ctrlr_claim_bus, .release_bus = spi_ctrlr_release_bus, .xfer = spi_ctrlr_xfer, - .xfer_vector = spi_xfer_two_vectors, .max_xfer_size = MAX_PACKET_COUNT, }; -- cgit v1.2.3