From fddcae7f4851e22177b0b72fd7aec1acc37c4eff Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Wed, 17 Jan 2024 16:10:58 -0600 Subject: soc/intel/common/block/sata: Add ACPI stub for SATA device Add an ACPI stub containing the SATA device in proper scope, along with the device status, so that there exists a device to be referenced from the PEPD LPI constraint list. Fixes a Windows BSOD INTERNAL_POWER_ERROR on devices with enabled SATA ports. TEST=build/boot Win11 on google/puff (kaisa). Change-Id: I951c62d09609ed73079fe97ea9ce49fdee333272 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/c/coreboot/+/80058 Tested-by: build bot (Jenkins) Reviewed-by: Felix Singer Reviewed-by: Eric Lai --- src/soc/intel/common/block/sata/sata.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) (limited to 'src/soc/intel') diff --git a/src/soc/intel/common/block/sata/sata.c b/src/soc/intel/common/block/sata/sata.c index 41e31fe19c..96c33ef0db 100644 --- a/src/soc/intel/common/block/sata/sata.c +++ b/src/soc/intel/common/block/sata/sata.c @@ -1,8 +1,26 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include +#include #include #include #include +#include + +static void sata_acpi_fill_ssdt(const struct device *dev) +{ + const char *scope = acpi_device_path(dev); + + if (!scope) + return; + + acpigen_write_scope(scope); + acpigen_write_device(soc_acpi_name(dev)); + acpigen_write_ADR_pci_device(dev); + acpigen_write_STA(acpi_device_status(dev)); + acpigen_pop_len(); /* Device */ + acpigen_pop_len(); /* Scope */ +} struct device_operations sata_ops = { .read_resources = pci_dev_read_resources, @@ -10,6 +28,9 @@ struct device_operations sata_ops = { .enable_resources = pci_dev_enable_resources, .final = pci_dev_request_bus_master, .ops_pci = &pci_dev_ops_pci, +#if CONFIG(HAVE_ACPI_TABLES) + .acpi_fill_ssdt = sata_acpi_fill_ssdt, +#endif }; static const unsigned short pci_device_ids[] = { -- cgit v1.2.3