From ecfdb43afacfb32c3a632288747afd705c89ba87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20=C5=BBygowski?= Date: Mon, 7 Nov 2022 19:23:47 +0100 Subject: soc/intel/elkhartlake/gpio.c: Fix GPD reset map MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The reset bit mapping was incorrectly assigned to GPIO groups. The reset mapping for Community 0 actually reflects the GPD reset mapping. Change the Community 0 reset mapping to the correct default map and fix the GPD reset mapping. Signed-off-by: Michał Żygowski Change-Id: I2b9d093ca7ea0f5087f49671ca457c0b45927918 Reviewed-on: https://review.coreboot.org/c/coreboot/+/72406 Tested-by: build bot (Jenkins) Reviewed-by: Mario Scheithauer Reviewed-by: Lean Sheng Tan --- src/soc/intel/elkhartlake/gpio.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/soc/intel') diff --git a/src/soc/intel/elkhartlake/gpio.c b/src/soc/intel/elkhartlake/gpio.c index d329b52029..1b07bc5d27 100644 --- a/src/soc/intel/elkhartlake/gpio.c +++ b/src/soc/intel/elkhartlake/gpio.c @@ -11,7 +11,7 @@ static const struct reset_mapping rst_map[] = { { .logical = PAD_CFG0_LOGICAL_RESET_PLTRST, .chipset = 2U << 30 }, }; -static const struct reset_mapping rst_map_com0[] = { +static const struct reset_mapping rst_map_gpd[] = { { .logical = PAD_CFG0_LOGICAL_RESET_PWROK, .chipset = 0U << 30 }, { .logical = PAD_CFG0_LOGICAL_RESET_DEEP, .chipset = 1U << 30 }, { .logical = PAD_CFG0_LOGICAL_RESET_PLTRST, .chipset = 2U << 30 }, @@ -88,8 +88,8 @@ static const struct pad_community ehl_communities[TOTAL_GPIO_COMM] = { .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPP_BTG", .acpi_path = "\\_SB.PCI0.GPIO", - .reset_map = rst_map_com0, - .num_reset_vals = ARRAY_SIZE(rst_map_com0), + .reset_map = rst_map, + .num_reset_vals = ARRAY_SIZE(rst_map), .groups = ehl_community0_groups, .num_groups = ARRAY_SIZE(ehl_community0_groups), }, @@ -130,8 +130,8 @@ static const struct pad_community ehl_communities[TOTAL_GPIO_COMM] = { .max_pads_per_group = GPIO_MAX_NUM_PER_GROUP, .name = "GPD", .acpi_path = "\\_SB.PCI0.GPIO", - .reset_map = rst_map, - .num_reset_vals = ARRAY_SIZE(rst_map), + .reset_map = rst_map_gpd, + .num_reset_vals = ARRAY_SIZE(rst_map_gpd), .groups = ehl_community2_groups, .num_groups = ARRAY_SIZE(ehl_community2_groups), }, -- cgit v1.2.3