From d890b45520a4b2af2ae2b15096b5897ed7464fcb Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Thu, 10 Dec 2015 08:04:44 -0700 Subject: ACPI: Add hack to avoid IASL warning when reading back registers Upcoming versions of IASL give a warning about unused methods. This adds an operation after the read to use the local variable and avoid the warning. The warning can be completely disabled on the command line, but as it can find real issues, my preference is to not do that. Fixes warnings: dsdt.aml 640: Store (CTMP, Local0) Warning 3144 - Method Local is set but never used ^ (Local0) Change-Id: If55bb8e03abb8861e1f2f08a8bcb1be8c9783afe Signed-off-by: Martin Roth Reviewed-on: https://review.coreboot.org/12704 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer --- src/soc/intel/broadwell/acpi/serialio.asl | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/soc/intel') diff --git a/src/soc/intel/broadwell/acpi/serialio.asl b/src/soc/intel/broadwell/acpi/serialio.asl index a6c94d243f..1b44e9566a 100644 --- a/src/soc/intel/broadwell/acpi/serialio.asl +++ b/src/soc/intel/broadwell/acpi/serialio.asl @@ -36,6 +36,9 @@ Method (LPD0, 2, Serialized) And (SPCS, 0xFFFFFFFC, SPCS) Store (SPCS, Local0) // Read back after writing + + // Use Local0 to avoid iasl warning: Method Local is set but never used + And(Local0, Ones, Local0) } // Put SerialIO device in D3 state @@ -56,6 +59,9 @@ Method (LPD3, 2, Serialized) Or (SPCS, 0x3, SPCS) Store (SPCS, Local0) // Read back after writing + + // Use Local0 to avoid iasl warning: Method Local is set but never used + And(Local0, Ones, Local0) } // Serial IO Resource Consumption for BAR1 -- cgit v1.2.3