From b8fba86b143b471a2126411177b0236f08358b8e Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Wed, 17 Jun 2020 21:06:53 +0200 Subject: Kconfig: Escape variable to accommodate new Kconfig versions Kconfig 4.17 started using the $(..) syntax for environment variable expansion while we want to keep expansion to the build system. Older Kconfig versions (like ours) simply drop the escapes, not changing the behavior. While we could let Kconfig expand some of the variables, that only splits the handling in two places, making debugging harder and potentially messing with reproducible builds (e.g. when paths end up in configs), so escape them all. Change-Id: Ibc4087fdd76089352bd8dd0edb1351ec79ea4faa Signed-off-by: Patrick Georgi Reviewed-on: https://review.coreboot.org/c/coreboot/+/42481 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh Reviewed-by: Paul Menzel Reviewed-by: Frans Hendriks Reviewed-by: Wim Vervoorn --- src/soc/intel/apollolake/Kconfig | 4 ++-- src/soc/intel/braswell/Kconfig | 2 +- src/soc/intel/quark/Kconfig | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src/soc/intel') diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index 3f82215ffc..f837a2e686 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -218,7 +218,7 @@ config LBP2_FROM_IFWI config LBP2_FILE_NAME string "Path of file to write to logical boot partition 2 region" depends on NEED_LBP2 && !LBP2_FROM_IFWI - default "3rdparty/blobs/mainboard/$(CONFIG_MAINBOARD_DIR)/lbp2.bin" + default "3rdparty/blobs/mainboard/\$(CONFIG_MAINBOARD_DIR)/lbp2.bin" help Name of file to store in the logical boot partition 2 region. @@ -239,7 +239,7 @@ config IFWI_FMAP_NAME config IFWI_FILE_NAME string "Path of file to write to IFWI region" depends on NEED_IFWI - default "3rdparty/blobs/mainboard/$(CONFIG_MAINBOARD_DIR)/ifwi.bin" + default "3rdparty/blobs/mainboard/\$(CONFIG_MAINBOARD_DIR)/ifwi.bin" help Name of file to store in the IFWI region. diff --git a/src/soc/intel/braswell/Kconfig b/src/soc/intel/braswell/Kconfig index 40ac213eb5..0acfeaa472 100644 --- a/src/soc/intel/braswell/Kconfig +++ b/src/soc/intel/braswell/Kconfig @@ -126,7 +126,7 @@ config USE_GOOGLE_FSP config FSP_HEADER_PATH string - default "$(src)/vendorcode/intel/fsp/fsp1_1/braswell" if USE_GOOGLE_FSP + default "\$(src)/vendorcode/intel/fsp/fsp1_1/braswell" if USE_GOOGLE_FSP default "3rdparty/fsp/BraswellFspBinPkg/Include/" help Location of FSP header file FspUpdVpd.h diff --git a/src/soc/intel/quark/Kconfig b/src/soc/intel/quark/Kconfig index 4ecf6c1a14..6571eb24f8 100644 --- a/src/soc/intel/quark/Kconfig +++ b/src/soc/intel/quark/Kconfig @@ -178,11 +178,11 @@ config FSP_ESRAM_LOC config FSP_M_FILE string - default "3rdparty/blobs/soc/intel/quark/$(CONFIG_FSP_TYPE)/$(CONFIG_FSP_BUILD_TYPE)/FSP_M.fd" + default "3rdparty/blobs/soc/intel/quark/\$(CONFIG_FSP_TYPE)/\$(CONFIG_FSP_BUILD_TYPE)/FSP_M.fd" config FSP_S_FILE string - default "3rdparty/blobs/soc/intel/quark/$(CONFIG_FSP_TYPE)/$(CONFIG_FSP_BUILD_TYPE)/FSP_S.fd" + default "3rdparty/blobs/soc/intel/quark/\$(CONFIG_FSP_TYPE)/\$(CONFIG_FSP_BUILD_TYPE)/FSP_S.fd" ##### # RMU binary -- cgit v1.2.3