From b628beca3428731b6ea43218caa27bdaf8eb651d Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Thu, 19 Jan 2023 18:58:30 -0700 Subject: drivers/intel/gma: Use libgfxinit Update_Output to turn off graphics We were using the libgfxinit `Initialize' function with the `Clean_State' parameter because the more appropriate `Update_Output' function was not performing all the necessary clean up operations for the PEIM driver to be successful when libgfxinit was used in romstage. Thanks to a lot of experiments and some log analysis efforts, we were able to identify the missing operation and fix the `Update_Output' function (cf. https://review.coreboot.org/c/libgfxinit/+/72123). The `initialized' global variable is now unnecessary as we track the initialization in the Ada code instead. Since the `Update_Output' function does not return any value, this patch modifies the `gma_gfxstop' prototype accordingly. This does not have any impact as the return value was not used anyway. BUG=b:264526798 BRANCH=firmware-brya-14505.B TEST=Developer screen is visible Change-Id: I53d6fadf65dc09bd984de96edb4c1f15b64aeed0 Signed-off-by: Jeremy Compostella Reviewed-on: https://review.coreboot.org/c/coreboot/+/72125 Reviewed-by: Tarun Tuli Tested-by: build bot (Jenkins) Reviewed-by: Nick Vaccaro --- src/soc/intel/common/block/graphics/early_graphics.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'src/soc/intel') diff --git a/src/soc/intel/common/block/graphics/early_graphics.c b/src/soc/intel/common/block/graphics/early_graphics.c index 3ae7697de3..8157a4c284 100644 --- a/src/soc/intel/common/block/graphics/early_graphics.c +++ b/src/soc/intel/common/block/graphics/early_graphics.c @@ -6,8 +6,6 @@ #include #include -static bool initialized; - static void device_init(void) { /* Disable response in IO and MMIO space. */ @@ -37,19 +35,15 @@ bool early_graphics_init(void) early_graphics_soc_panel_init(); gma_gfxinit(&ret); - initialized = !!ret; - - return initialized; + return !!ret; } void early_graphics_stop(void) { - int ret; - - if (!initialized) + if (!CONFIG(MAINBOARD_USE_EARLY_LIBGFXINIT)) return; - gma_gfxstop(&ret); + gma_gfxstop(); /* * Temporary workaround -- cgit v1.2.3