From ab1d2ac626d0535191b5f612707ae8f22c46c538 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Sun, 30 Jul 2017 13:47:06 +0300 Subject: usbdebug: Remove redundant setup MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Taking ownership is handled with DBGP_OWNER within usbdebug driver code. Change-Id: Ia5da10d385cda1b4968f812967ea8a54d7e3c974 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/20824 Tested-by: build bot (Jenkins) Reviewed-by: David Guckian Reviewed-by: Stefan Reinauer --- src/soc/intel/broadwell/Kconfig | 4 ---- src/soc/intel/broadwell/usb_debug.c | 7 ------- 2 files changed, 11 deletions(-) (limited to 'src/soc/intel') diff --git a/src/soc/intel/broadwell/Kconfig b/src/soc/intel/broadwell/Kconfig index 51322012d0..9d6f978a67 100644 --- a/src/soc/intel/broadwell/Kconfig +++ b/src/soc/intel/broadwell/Kconfig @@ -185,10 +185,6 @@ config EHCI_BAR hex default 0xd8000000 -config EHCI_DEBUG_OFFSET - hex - default 0xa0 - config SERIRQ_CONTINUOUS_MODE bool default y diff --git a/src/soc/intel/broadwell/usb_debug.c b/src/soc/intel/broadwell/usb_debug.c index fffebf00c6..683b4cc522 100644 --- a/src/soc/intel/broadwell/usb_debug.c +++ b/src/soc/intel/broadwell/usb_debug.c @@ -41,8 +41,6 @@ void pci_ehci_dbg_set_port(pci_devfn_t dev, unsigned int port) void pci_ehci_dbg_enable(pci_devfn_t dev, unsigned long base) { - u32 tmp32; - if (!dev) return; @@ -51,9 +49,4 @@ void pci_ehci_dbg_enable(pci_devfn_t dev, unsigned long base) /* Enable access to the EHCI memory space registers. */ pci_write_config8(dev, PCI_COMMAND, PCI_COMMAND_MEMORY); - - /* Force ownership of hte Debug Port to the EHCI controller. */ - tmp32 = read32((void *)(base + CONFIG_EHCI_DEBUG_OFFSET)); - tmp32 |= (1 << 30); - write32((void *)(base + CONFIG_EHCI_DEBUG_OFFSET), tmp32); } -- cgit v1.2.3