From a0720431b4c0685634fd1ccc45938e9b3cc40544 Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Sat, 3 Dec 2022 19:35:53 +0200 Subject: sb,soc/intel: Fix SMI handler IO trap data mask MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Shift is done in multiples of 8 (1 << 3) bits. It was fixed already for i82801ix/jx. Change-Id: I5e1c2b3bf4ba68f34eb43e59fe783d5cd6e0a39a Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/70361 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- src/soc/intel/broadwell/pch/smihandler.c | 2 +- src/soc/intel/common/block/smm/smitraphandler.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src/soc/intel') diff --git a/src/soc/intel/broadwell/pch/smihandler.c b/src/soc/intel/broadwell/pch/smihandler.c index a8e206783d..b9d5e50482 100644 --- a/src/soc/intel/broadwell/pch/smihandler.c +++ b/src/soc/intel/broadwell/pch/smihandler.c @@ -429,7 +429,7 @@ static void southbridge_smi_monitor(void) trap_cycle = RCBA32(0x1e10); for (i = 16; i < 20; i++) { if (trap_cycle & (1 << i)) - mask |= (0xff << ((i - 16) << 2)); + mask |= (0xff << ((i - 16) << 3)); } /* IOTRAP(3) SMI function call */ diff --git a/src/soc/intel/common/block/smm/smitraphandler.c b/src/soc/intel/common/block/smm/smitraphandler.c index 99825f10ba..42bab8388b 100644 --- a/src/soc/intel/common/block/smm/smitraphandler.c +++ b/src/soc/intel/common/block/smm/smitraphandler.c @@ -70,7 +70,7 @@ void smihandler_southbridge_monitor( trap_cycle = pcr_read32(PID_PSTH, PCR_PSTH_TRPC); for (i = 16; i < 20; i++) { if (trap_cycle & (1 << i)) - mask |= (0xff << ((i - 16) << 2)); + mask |= (0xff << ((i - 16) << 3)); } /* IOTRAP(3) SMI function call */ -- cgit v1.2.3