From 9641c0e1023ca137e76762e11425695c34c1edbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Fri, 28 Apr 2023 08:30:00 +0300 Subject: soc/intel/xeon_sp/spr: Drop spurious FADT fields MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Assigning duty_offset while duty_width==0 has no purpose. Under intel/common/block, previous assignment for fadt->gpe0_blk resolves GPE0_STS(0) from xeon_sp/ebg/.../soc_pm.h and also assigns value matching pmbase + 0x60. Change-Id: Iaf688d9471ac527ac20307cf16216abdab731a06 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/74827 Reviewed-by: Paul Menzel Reviewed-by: Elyes Haouas Tested-by: build bot (Jenkins) --- src/soc/intel/xeon_sp/spr/soc_acpi.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/soc/intel') diff --git a/src/soc/intel/xeon_sp/spr/soc_acpi.c b/src/soc/intel/xeon_sp/spr/soc_acpi.c index 0233c37967..18ebe721c4 100644 --- a/src/soc/intel/xeon_sp/spr/soc_acpi.c +++ b/src/soc/intel/xeon_sp/spr/soc_acpi.c @@ -47,8 +47,6 @@ void soc_fill_fadt(acpi_fadt_t *fadt) fadt->preferred_pm_profile = PM_ENTERPRISE_SERVER; fadt->pm2_cnt_blk = pmbase + PM2_CNT; fadt->pm2_cnt_len = 1; - fadt->gpe0_blk = pmbase + 0x60; - fadt->duty_offset = 1; fadt->x_pm1b_evt_blk.space_id = ACPI_ADDRESS_SPACE_IO; fadt->x_pm1b_cnt_blk.space_id = ACPI_ADDRESS_SPACE_IO; -- cgit v1.2.3