From 94030cfa558257e5453402867feb443cd7505a91 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Mon, 15 Nov 2021 12:10:56 +0530 Subject: soc/intel/../thermal: Drop `ltt_value` local variable Using the `GET_LTT_VALUE` macro directly instead of 'ltt_value' local variable. BUG=b:193774296 Change-Id: I791766bf2a78fa30dbba8cf4ad8a50e44f0e73ed Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/59309 Tested-by: build bot (Jenkins) Reviewed-by: Maulik V Vaghela Reviewed-by: EricR Lai Reviewed-by: Angel Pons --- src/soc/intel/common/block/thermal/thermal.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src/soc/intel') diff --git a/src/soc/intel/common/block/thermal/thermal.c b/src/soc/intel/common/block/thermal/thermal.c index f88699531e..6211f35bd1 100644 --- a/src/soc/intel/common/block/thermal/thermal.c +++ b/src/soc/intel/common/block/thermal/thermal.c @@ -11,6 +11,7 @@ #define MAX_TRIP_TEMP 205 /* This is the safest default Trip Temp value */ #define DEFAULT_TRIP_TEMP 50 +/* Trip Point Temp = (LTT / 2 - 50 degree C) */ #define GET_LTT_VALUE(x) (((x) + 50) * (2)) static uint8_t get_thermal_trip_temp(void) @@ -24,7 +25,6 @@ static uint8_t get_thermal_trip_temp(void) /* PCH Low Temp Threshold (LTT) */ static uint16_t pch_get_ltt_value(struct device *dev) { - uint16_t ltt_value; uint8_t thermal_config; thermal_config = get_thermal_trip_temp(); @@ -34,10 +34,7 @@ static uint16_t pch_get_ltt_value(struct device *dev) if (thermal_config > MAX_TRIP_TEMP) die("Input PCH temp trip is higher than allowed range!"); - /* Trip Point Temp = (LTT / 2 - 50 degree C) */ - ltt_value = GET_LTT_VALUE(thermal_config); - - return ltt_value; + return GET_LTT_VALUE(thermal_config); } /* Enable thermal sensor power management */ -- cgit v1.2.3