From 91f955e31f0490933b32087bdd52840aa8cf0692 Mon Sep 17 00:00:00 2001 From: Andrey Petrov Date: Tue, 10 Sep 2019 11:14:00 -0700 Subject: soc/fsp_broadwell_de: Use DIMM numbers relative to channel Currently "DIMM numbers" increase monotonically for all the channels. However, commonly DIMMS are numerated on per-channel basis. This change makes numeration match the convention. TEST=on OCP monolake, run dmidecode tool and see that "Locator" field matches expectation. Change-Id: I3e7858545471867a0210e1b9ef646529b8e2a31c Signed-off-by: Andrey Petrov Reviewed-on: https://review.coreboot.org/c/coreboot/+/35318 Reviewed-by: Patrick Rudolph Reviewed-by: David Hendricks Tested-by: build bot (Jenkins) --- src/soc/intel/fsp_broadwell_de/romstage/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/soc/intel') diff --git a/src/soc/intel/fsp_broadwell_de/romstage/memory.c b/src/soc/intel/fsp_broadwell_de/romstage/memory.c index 7574c5fb66..afbf97bf57 100644 --- a/src/soc/intel/fsp_broadwell_de/romstage/memory.c +++ b/src/soc/intel/fsp_broadwell_de/romstage/memory.c @@ -54,7 +54,7 @@ void save_dimm_info(void) dimm_attr dimm = {0}; u8 *spd_data = blk.spd_array[index]; if (spd_decode_ddr4(&dimm, spd_data) == SPD_STATUS_OK) - spd_add_smbios17_ddr4(channel, index, dclk_mhz, &dimm); + spd_add_smbios17_ddr4(channel, slot, dclk_mhz, &dimm); index++; } } -- cgit v1.2.3