From bfb11bec3b3fec638adf864a9b9b2cff6671fed8 Mon Sep 17 00:00:00 2001 From: Nicholas Sudsgaard Date: Tue, 30 Jan 2024 09:53:46 +0900 Subject: include/device/device.h: Remove CHIP_NAME() macro Macros can be confusing on their own; hiding commas make things worse. This can sometimes be downright misleading. A "good" example would be the code in soc/intel/xeon_sp/spr/chip.c: CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, This appears as CHIP_NAME() being some struct when in fact these are defining 2 separate members of the same struct. It was decided to remove this macro altogether, as it does not do anything special and incurs a maintenance burden. Change-Id: Iaed6dfb144bddcf5c43634b0c955c19afce388f0 Signed-off-by: Nicholas Sudsgaard Reviewed-on: https://review.coreboot.org/c/coreboot/+/80239 Reviewed-by: Yidi Lin Reviewed-by: Felix Singer Reviewed-by: Jakub Czapiga Tested-by: build bot (Jenkins) Reviewed-by: Matt DeVillier --- src/soc/intel/xeon_sp/spr/chip.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/soc/intel/xeon_sp/spr') diff --git a/src/soc/intel/xeon_sp/spr/chip.c b/src/soc/intel/xeon_sp/spr/chip.c index 3b3c65e4a0..abab0d2413 100644 --- a/src/soc/intel/xeon_sp/spr/chip.c +++ b/src/soc/intel/xeon_sp/spr/chip.c @@ -159,7 +159,8 @@ static void chip_init(void *data) } struct chip_operations soc_intel_xeon_sp_spr_ops = { - CHIP_NAME("Intel SapphireRapids-SP").enable_dev = chip_enable_dev, + .name = "Intel SapphireRapids-SP", + .enable_dev = chip_enable_dev, .init = chip_init, .final = chip_final, }; -- cgit v1.2.3