From 3625b0e0eee8a6fff230199c370e5d74579898b2 Mon Sep 17 00:00:00 2001 From: Patrick Rudolph Date: Thu, 17 Oct 2024 15:08:51 +0200 Subject: soc/intel/xeon_sp: Add SAD PCI driver Get rid of some helper functions by properly using a pci_driver. Configure SAD if necessary and lock SAD if necessary in the newly added SAD PCI driver. This allows to drop lock_pam0123(), unlock_pam_regions() and socket0_get_ubox_busno(). - Fixes SAD instance on secondary sockets not decoding the C-F segments as DRAM, which would prevent those sockets to access the ACPI/SMBIOS table anchor - Adds PCI multi segment support (SKX and CPX only, other were working properly already) - Moves locking of PAM0123_CSR and PAM456_CSR from SoC to driver code Change-Id: I167b6ce48631fe3f97359ee33704f52ca854dbd1 Signed-off-by: Patrick Rudolph Reviewed-on: https://review.coreboot.org/c/coreboot/+/84794 Reviewed-by: Shuo Liu Tested-by: build bot (Jenkins) --- src/soc/intel/xeon_sp/skx/include/soc/soc_util.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/soc/intel/xeon_sp/skx/include') diff --git a/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h b/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h index b8c000e130..4345e4646e 100644 --- a/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h +++ b/src/soc/intel/xeon_sp/skx/include/soc/soc_util.h @@ -13,8 +13,6 @@ void config_reset_cpl3_csrs(void); const struct SystemMemoryMapHob *get_system_memory_map(void); -uint8_t socket0_get_ubox_busno(const uint8_t stack); - int soc_get_stack_for_port(int port); uint8_t get_cxl_node_count(void); -- cgit v1.2.3