From 9ec7227c9b43df97e3422877b2539db21d47741b Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Sun, 17 Oct 2021 08:34:31 +0300 Subject: cpu/x86/lapic: Move LAPIC configuration to MP init MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Implementation for setup_lapic() did two things -- call enable_lapic() and virtual_wire_mode_init(). In PARALLEL_MP case enable_lapic() was redundant as it was already executed prior to initialize_cpu() call. For the !PARALLEL_MP case enable_lapic() is added to AP CPUs. Change-Id: I5caf94315776a499e9cf8f007251b61f51292dc5 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/58387 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/soc/intel/tigerlake/cpu.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'src/soc/intel/tigerlake/cpu.c') diff --git a/src/soc/intel/tigerlake/cpu.c b/src/soc/intel/tigerlake/cpu.c index d225c504c8..ffccdccf44 100644 --- a/src/soc/intel/tigerlake/cpu.c +++ b/src/soc/intel/tigerlake/cpu.c @@ -7,7 +7,6 @@ */ #include -#include #include #include #include @@ -76,9 +75,7 @@ void soc_core_init(struct device *cpu) * every bank. */ mca_configure(); - /* Enable the local CPU apics */ enable_lapic_tpr(); - setup_lapic(); /* Configure Enhanced SpeedStep and Thermal Sensors */ configure_misc(); -- cgit v1.2.3