From a6c5ddd595e145ffd091a9fcadb5e0ffbf0fa8d1 Mon Sep 17 00:00:00 2001 From: Furquan Shaikh Date: Fri, 22 Jul 2016 06:59:40 -0700 Subject: vboot: Clean up vboot code 1. Remove unused functions/structures. 2. Add checks for NULL return values. 3. Change prefixes to vb2 instead of vboot for functions used internally within vboot2/ 4. Get rid of vboot_handoff.h file and move the structure definition to vboot_common.h 5. Rename all functions using handoff structure to have prefix vboot_handoff_*. All the handoff functions can be run _only_ after cbmem is online. 6. Organize vboot_common.h content according to different functionalities. BUG=chrome-os-partner:55431 Change-Id: I4c07d50327d88cddbdfbb0b6f82c264e2b8620eb Signed-off-by: Furquan Shaikh Reviewed-on: https://review.coreboot.org/15799 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- src/soc/intel/skylake/fsp_reset.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'src/soc/intel/skylake') diff --git a/src/soc/intel/skylake/fsp_reset.c b/src/soc/intel/skylake/fsp_reset.c index 4751872a47..f25f1572f5 100644 --- a/src/soc/intel/skylake/fsp_reset.c +++ b/src/soc/intel/skylake/fsp_reset.c @@ -13,7 +13,7 @@ * GNU General Public License for more details. */ #include -#include +#include static int is_recovery; /* flag to identify recovery mode */ @@ -35,8 +35,10 @@ static void set_recovery_request(void *unused) * Set recovery flag during Recovery Mode Silicon Init * & store recovery request into VBNV */ - if (is_recovery) - set_recovery_mode_into_vbnv(vboot_recovery_reason()); + if (is_recovery) { + int reason = vboot_handoff_get_recovery_reason(); + set_recovery_mode_into_vbnv(reason); + } } -- cgit v1.2.3