From 87f67bc69912c8725769481d70352eef894baa3a Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Fri, 22 Sep 2017 00:05:28 -0500 Subject: soc/intel/skylake: add acoustic noise mitigation params for FSP 1.1 Adapted from Chromium commit d6655eb [Skylake: create UPD Interface for acoustic noise tuning] Add FSP 1.1 params needed for acoustic mitigation on google/caroline (to be upstreamed in a subsequent commit). TEST: build/boot google/caroline Change-Id: Ifb36ecef8c1735c63a5322d952929e9c34cddfb9 Signed-off-by: Matt DeVillier Reviewed-on: https://review.coreboot.org/22524 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Stefan Reinauer --- src/soc/intel/skylake/chip.c | 22 ++++++++++++++++++++++ src/soc/intel/skylake/chip.h | 3 +++ 2 files changed, 25 insertions(+) (limited to 'src/soc/intel/skylake') diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c index 3e33053abb..4909ea4ccb 100644 --- a/src/soc/intel/skylake/chip.c +++ b/src/soc/intel/skylake/chip.c @@ -196,6 +196,13 @@ void soc_silicon_init_params(SILICON_INIT_UPD *params) params->SendVrMbxCmd = config->SendVrMbxCmd; + /* Acoustic Noise Mitigation */ + params->AcousticNoiseMitigation = config->AcousticNoiseMitigation; + params->SlowSlewRateForIa = config->SlowSlewRateForIa; + params->SlowSlewRateForGt = config->SlowSlewRateForGt; + params->SlowSlewRateForSa = config->SlowSlewRateForSa; + params->FastPkgCRampDisable = config->FastPkgCRampDisable; + soc_irq_settings(params); } @@ -801,6 +808,21 @@ void soc_display_silicon_init_params(const SILICON_INIT_UPD *original, fsp_display_upd_value("SendVrMbxCmd", 1, original->SendVrMbxCmd, params->SendVrMbxCmd); + fsp_display_upd_value("AcousticNoiseMitigation", 1, + original->AcousticNoiseMitigation, + params->AcousticNoiseMitigation); + fsp_display_upd_value("SlowSlewRateForIa", 1, + original->SlowSlewRateForIa, + params->SlowSlewRateForIa); + fsp_display_upd_value("SlowSlewRateForGt", 1, + original->SlowSlewRateForGt, + params->SlowSlewRateForGt); + fsp_display_upd_value("SlowSlewRateForSa", 1, + original->SlowSlewRateForSa, + params->SlowSlewRateForSa); + fsp_display_upd_value("FastPkgCRampDisable", 1, + original->FastPkgCRampDisable, + params->FastPkgCRampDisable); } static void pci_set_subsystem(device_t dev, unsigned int vendor, diff --git a/src/soc/intel/skylake/chip.h b/src/soc/intel/skylake/chip.h index 4db8382d68..a7804af14f 100644 --- a/src/soc/intel/skylake/chip.h +++ b/src/soc/intel/skylake/chip.h @@ -485,6 +485,9 @@ struct soc_intel_skylake_config { * 0b - Enabled * 1b - Disabled */ + /* FSP 1.1 */ + u8 FastPkgCRampDisable; + /* FSP 2.0 */ u8 FastPkgCRampDisableIa; u8 FastPkgCRampDisableGt; u8 FastPkgCRampDisableSa; -- cgit v1.2.3