From 5d98dabb4e10cb93cae9b43f47dc3c4fe1fefd5f Mon Sep 17 00:00:00 2001 From: Angel Pons Date: Fri, 19 Feb 2021 22:01:55 +0100 Subject: soc/intel: Drop `bootblock_cpu_init()` function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Just call `fast_spi_cache_bios_region()` directly instead. Change-Id: I99f6ed4cf1a5c49b078cfd05e357c2d4c26ade45 Signed-off-by: Angel Pons Reviewed-on: https://review.coreboot.org/c/coreboot/+/50952 Reviewed-by: Michael Niewöhner Tested-by: build bot (Jenkins) --- src/soc/intel/skylake/Makefile.inc | 1 - src/soc/intel/skylake/bootblock/bootblock.c | 3 ++- src/soc/intel/skylake/bootblock/cpu.c | 9 --------- src/soc/intel/skylake/include/soc/bootblock.h | 1 - 4 files changed, 2 insertions(+), 12 deletions(-) delete mode 100644 src/soc/intel/skylake/bootblock/cpu.c (limited to 'src/soc/intel/skylake') diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc index de516c1bbb..1d36feb438 100644 --- a/src/soc/intel/skylake/Makefile.inc +++ b/src/soc/intel/skylake/Makefile.inc @@ -11,7 +11,6 @@ subdirs-y += ../../../cpu/x86/smm subdirs-y += ../../../cpu/x86/tsc bootblock-y += bootblock/bootblock.c -bootblock-y += bootblock/cpu.c bootblock-y += i2c.c bootblock-y += bootblock/pch.c bootblock-y += bootblock/report_platform.c diff --git a/src/soc/intel/skylake/bootblock/bootblock.c b/src/soc/intel/skylake/bootblock/bootblock.c index 65c631a6e2..7b8b147aaa 100644 --- a/src/soc/intel/skylake/bootblock/bootblock.c +++ b/src/soc/intel/skylake/bootblock/bootblock.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include +#include #include #include #include @@ -17,7 +18,7 @@ void bootblock_soc_early_init(void) { bootblock_systemagent_early_init(); bootblock_pch_early_init(); - bootblock_cpu_init(); + fast_spi_cache_bios_region(); pch_early_iorange_init(); if (CONFIG(INTEL_LPSS_UART_FOR_CONSOLE)) diff --git a/src/soc/intel/skylake/bootblock/cpu.c b/src/soc/intel/skylake/bootblock/cpu.c deleted file mode 100644 index bf487c3623..0000000000 --- a/src/soc/intel/skylake/bootblock/cpu.c +++ /dev/null @@ -1,9 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -#include -#include - -void bootblock_cpu_init(void) -{ - fast_spi_cache_bios_region(); -} diff --git a/src/soc/intel/skylake/include/soc/bootblock.h b/src/soc/intel/skylake/include/soc/bootblock.h index 5e677357b0..90c4a405b6 100644 --- a/src/soc/intel/skylake/include/soc/bootblock.h +++ b/src/soc/intel/skylake/include/soc/bootblock.h @@ -4,7 +4,6 @@ #define _SOC_SKYLAKE_BOOTBLOCK_H_ /* Bootblock pre console init programming */ -void bootblock_cpu_init(void); void bootblock_pch_early_init(void); /* Bootblock post console init programming */ -- cgit v1.2.3