From a1b3547f0f6e08ad2c83c0224e375217bf187120 Mon Sep 17 00:00:00 2001 From: Naresh G Solanki Date: Fri, 11 Dec 2015 18:13:02 +0530 Subject: intel/skylake: Fix issues found by klockwork src/soc/intel/skylake/acpi.c Function cbmem_find may return NULL, check before using its result. src/soc/intel/skylake/flash_controller.c Remove dead code: spi_claim_bus is a no-op, always returning 0. src/soc/intel/skylake/gpio.c Check for NULL before using pointers. src/soc/intel/skylake/igd.c Don't copy 0-termination of signature string. src/soc/intel/skylake/lpc.c Don't check unsigned >= 0. src/soc/intel/skylake/systemagent.c Explicitly cast result to 64bit. BRANCH=None BUG=chrome-os-partner:48542 TEST=Built & booted Kunimitsu board. Change-Id: I6cbf4f78382383d3c8c3b15f66c5898ab5bf183a Signed-off-by: Patrick Georgi Original-Commit-Id: d98a8cdd3d095a6943c0e104cd4938639a62bd14 Original-Change-Id: Id2a31402618f4c9f6f53525ebcf6b71fd67428db Original-Signed-off-by: Naresh G Solanki Original-Reviewed-on: https://chromium-review.googlesource.com/317522 Original-Commit-Ready: Naresh Solanki Original-Tested-by: Naresh Solanki Original-Reviewed-by: Aaron Durbin Reviewed-on: https://review.coreboot.org/12991 Reviewed-by: Martin Roth Tested-by: build bot (Jenkins) --- src/soc/intel/skylake/gpio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/soc/intel/skylake/gpio.c') diff --git a/src/soc/intel/skylake/gpio.c b/src/soc/intel/skylake/gpio.c index 64b3dda334..db4b8c3ce6 100644 --- a/src/soc/intel/skylake/gpio.c +++ b/src/soc/intel/skylake/gpio.c @@ -261,6 +261,9 @@ static void gpio_handle_pad_mode(const struct pad_config *cfg) bit = 0; hostsw_own_reg = gpio_hostsw_reg(cfg->pad, &bit); + if (hostsw_own_reg == NULL) + return; + reg = read32(hostsw_own_reg); reg &= ~(1U << bit); @@ -282,7 +285,8 @@ static void gpi_enable_smi(gpio_t pad) uint32_t pad_mask; comm = gpio_get_community(pad); - + if (comm == NULL) + return; regs = pcr_port_regs(comm->port_id); gpi_status_reg = (void *)®s[GPI_SMI_STS_OFFSET]; gpi_en_reg = (void *)®s[GPI_SMI_EN_OFFSET]; -- cgit v1.2.3