From 46caf09598575747070c599dbfd9abca9e96b831 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Fri, 28 Sep 2018 19:54:30 +0530 Subject: soc/intel/skylake: Ensure FSP don't override ITSS IPCx registers This patch save and restore ITSS IPCx register before and after FSP-S call. Change-Id: Ib731f27826d604c305dc52a8488fd6240b01148a Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/28791 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin Reviewed-by: Furquan Shaikh --- src/soc/intel/skylake/chip.c | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'src/soc/intel/skylake/chip.c') diff --git a/src/soc/intel/skylake/chip.c b/src/soc/intel/skylake/chip.c index 9d9ca01d6d..fb011833e4 100644 --- a/src/soc/intel/skylake/chip.c +++ b/src/soc/intel/skylake/chip.c @@ -21,19 +21,28 @@ #include #include #include +#include #include #include #include #include #include +#include #include #include #include void soc_init_pre_device(void *chip_info) { + /* Snapshot the current GPIO IRQ polarities. FSP is setting a + * default policy that doesn't honor boards' requirements. */ + itss_snapshot_irq_polarities(GPIO_IRQ_START, GPIO_IRQ_END); + /* Perform silicon specific init. */ intel_silicon_init(); + + /* Restore GPIO IRQ polarities back to previous settings. */ + itss_restore_irq_polarities(GPIO_IRQ_START, GPIO_IRQ_END); } void soc_fsp_load(void) -- cgit v1.2.3