From b0672402ecedc7c8ca2e634437c603d73aebf471 Mon Sep 17 00:00:00 2001 From: Lee Leahy Date: Mon, 18 Jul 2016 10:39:55 -0700 Subject: soc/intel/quark: Fix legacy GPIO reads Add missing break to LEG_GPIO_REGS case to return the correct value for legacy GPIO reads. Fixes coverity issue CID 1357460. Found by Coverity, Fixes: * CID 1357460 (#1 of 1): Unused value (UNUSED_VALUE) returned_value: Assigning value from reg_legacy_gpio_read(step->reg) to value here, but that stored value is overwritten before it can be used. value_overwrite: Overwriting previous write to value with value from reg_pcie_afe_read(step->reg). TEST=Build and run on Galileo Gen2. Change-Id: I6c52e8801a32f510ac94276fe0c097850cbfde57 Signed-off-by: Lee Leahy Reviewed-on: https://review.coreboot.org/15732 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Martin Roth --- src/soc/intel/quark/reg_access.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/soc/intel/quark/reg_access.c') diff --git a/src/soc/intel/quark/reg_access.c b/src/soc/intel/quark/reg_access.c index c4688076ed..25a52ff762 100644 --- a/src/soc/intel/quark/reg_access.c +++ b/src/soc/intel/quark/reg_access.c @@ -251,6 +251,7 @@ static uint64_t reg_read(struct reg_script_context *ctx) case LEG_GPIO_REGS: ctx->display_prefix = "Legacy GPIO"; value = reg_legacy_gpio_read(step->reg); + break; case PCIE_AFE_REGS: ctx->display_prefix = "PCIe AFE"; -- cgit v1.2.3