From 2a3b9b2ad5849fa3980196f8733548b8976d804a Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Thu, 26 Sep 2024 10:50:09 -0700 Subject: soc/intel/pantherlake: Comply with the no typedef coding style rule As https://doc.coreboot.org/contributing/coding_style.html#typedefs states: "In general, a pointer, or a struct that has elements that can reasonably be directly accessed should never be a typedef". This commit makes the Intel Panther Lake SoC code comply with this by using explicitly `struct soc_intel_pantherlake_config' in the soc/intel/pantherlake code as I have been suggested to for the `fsp_params.c' files. The rule being the rule and consistency across a project matters more than personal preferences. The documentation lists five exceptions and none on them cover the use of `config_t' instead `struct soc_intel_pantherlake' but I believe it does not make the code better for the following three reasons: 1. It is repetitive, make the line longer and the code is in soc/intel/pantherlake so obviously the config_t data structure is the pantherlake soc configuration. 2. It makes re-usability from one generation to another unnecessarily harder. 3. This config_t abstraction is required for and used by some common block code anyway. Hence, we end-up with some code using `config_t' and other using the final structure which break the consistency of the code when the project in looked as a whole. BUG=348678529 TEST=Google fatcat mainboard compiles Change-Id: Ibe382615db1a7c7a0841d8fe4ae43c226e2c2021 Signed-off-by: Jeremy Compostella Reviewed-on: https://review.coreboot.org/c/coreboot/+/84561 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik Reviewed-by: Ronak Kanabar --- src/soc/intel/pantherlake/cpu.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'src/soc/intel/pantherlake/cpu.c') diff --git a/src/soc/intel/pantherlake/cpu.c b/src/soc/intel/pantherlake/cpu.c index 13a1d9ea24..7856383339 100644 --- a/src/soc/intel/pantherlake/cpu.c +++ b/src/soc/intel/pantherlake/cpu.c @@ -53,7 +53,7 @@ static void configure_misc(void) { msr_t msr; - config_t *conf = (config_t *)config_of_soc(); + const struct soc_intel_pantherlake_config *conf = config_of_soc(); msr = rdmsr(IA32_MISC_ENABLE); msr.lo |= FAST_STRINGS_ENABLE_BIT; @@ -123,7 +123,7 @@ void soc_core_init(struct device *cpu) /* Set energy policy */ set_energy_perf_bias(ENERGY_POLICY_NORMAL); - const config_t *conf = config_of_soc(); + const struct soc_intel_pantherlake_config *conf = config_of_soc(); /* Set energy-performance preference */ if (conf != NULL && conf->enable_energy_perf_pref) { if (check_energy_perf_cap()) @@ -152,7 +152,7 @@ static void pre_mp_init(void) { soc_fsp_load(); - const config_t *conf = config_of_soc(); + const struct soc_intel_pantherlake_config *conf = config_of_soc(); if (conf == NULL) { printk(BIOS_ERR, "Configuration could not be retrieved.\n"); return; -- cgit v1.2.3