From f9e877ea2173696028ded8e82fbe51e13085865b Mon Sep 17 00:00:00 2001 From: Jeremy Compostella Date: Tue, 1 Oct 2024 11:01:34 -0700 Subject: soc/intel/pantherlake: Remove soc_info.[hc] interface This commit removes the unnecessary layer provided by soc_info.[hc]. It was providing an abstraction which only was resulting in extra function calls without any added value as the returned constants are well identified and could be used directly. More importantly, and this is the actual selling point in my opinion, this extra indirection was preventing the compiler from detecting array overflows. BUG=348678529 TEST=Build is successful Change-Id: Iea26d962748116fa84afdb4afcba1098a64b6986 Signed-off-by: Jeremy Compostella Reviewed-on: https://review.coreboot.org/c/coreboot/+/84616 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik --- src/soc/intel/pantherlake/Makefile.mk | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/soc/intel/pantherlake/Makefile.mk') diff --git a/src/soc/intel/pantherlake/Makefile.mk b/src/soc/intel/pantherlake/Makefile.mk index 10ef8e949f..f3403b5143 100644 --- a/src/soc/intel/pantherlake/Makefile.mk +++ b/src/soc/intel/pantherlake/Makefile.mk @@ -18,14 +18,12 @@ bootblock-y += bootblock/bootblock.c bootblock-y += bootblock/pcd.c bootblock-y += bootblock/report_platform.c bootblock-y += espi.c -bootblock-y += soc_info.c romstage-$(CONFIG_SOC_INTEL_CSE_PRE_CPU_RESET_TELEMETRY) += cse_telemetry.c romstage-y += espi.c romstage-y += meminit.c romstage-y += pcie_rp.c romstage-y += reset.c -romstage-y += soc_info.c ramstage-y += acpi.c ramstage-y += chip.c @@ -41,7 +39,6 @@ ramstage-y += pcie_rp.c ramstage-y += pmc.c ramstage-y += reset.c ramstage-y += retimer.c -ramstage-y += soc_info.c ramstage-y += soundwire.c ramstage-y += systemagent.c ramstage-y += tcss.c @@ -52,7 +49,6 @@ smm-y += gpio.c smm-y += p2sb.c smm-y += pmutil.c smm-y += smihandler.c -smm-y += soc_info.c smm-y += uart.c smm-y += xhci.c CPPFLAGS_common += -I$(src)/soc/intel/pantherlake -- cgit v1.2.3