From 49bbfcd5d393b8c14b46e46f0b20f150e4930b3d Mon Sep 17 00:00:00 2001 From: Ben Gardner Date: Wed, 9 Dec 2015 11:17:51 -0600 Subject: intel/fsp_baytrail: Fix PCI_DEV_PIRQ_ROUTE macro ending The macro PCI_DEV_PIRQ_ROUTE ends with a comma and escaped newline. Ending a macro with an escaped newline is always wrong. The final comma is not necessary, as all uses of PCI_DEV_PIRQ_ROUTE() properly separate calls with a comma. I haven't investigated whether this is causing a real issue, but it should be leaving gaps in struct baytrail_irq_route.pcidev. The non-FSP baytrail does not have this issue. Change-Id: If6782176068b07cb3bc819c00d1cdb1b618bcea8 Signed-off-by: Ben Gardner Reviewed-on: https://review.coreboot.org/12696 Tested-by: build bot (Jenkins) Reviewed-by: Stefan Reinauer Reviewed-by: Werner Zeh --- src/soc/intel/fsp_baytrail/acpi/irq_helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/soc/intel/fsp_baytrail') diff --git a/src/soc/intel/fsp_baytrail/acpi/irq_helper.h b/src/soc/intel/fsp_baytrail/acpi/irq_helper.h index a8cf3efc65..8d18aeaeb3 100644 --- a/src/soc/intel/fsp_baytrail/acpi/irq_helper.h +++ b/src/soc/intel/fsp_baytrail/acpi/irq_helper.h @@ -85,7 +85,7 @@ Name(prefix_ ## func_ ## A, Package() \ ACPI_DEV_IRQ(dev_, 0, a_), \ ACPI_DEV_IRQ(dev_, 1, b_), \ ACPI_DEV_IRQ(dev_, 2, c_), \ - ACPI_DEV_IRQ(dev_, 3, d_), \ + ACPI_DEV_IRQ(dev_, 3, d_) #define PCIE_BRIDGE_DEV(prefix_, dev_, a_, b_, c_, d_) \ ROOTPORT_IRQ_ROUTES(prefix_, a_, b_, c_, d_) \ -- cgit v1.2.3