From 2787237dd52550b5d7e1dc3dabcf380126ff804c Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Thu, 21 Jan 2021 16:05:26 +0200 Subject: ACPI: Add helpers for CBMEM_ID_POWER_STATE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Create uniform logging for the (unlikely) case of a CBMEM entry disappearing. Change-Id: I7c5414a03d869423c8ae5192a990fde5f9582f2d Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/49817 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Felix Held --- src/soc/intel/elkhartlake/pmutil.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'src/soc/intel/elkhartlake') diff --git a/src/soc/intel/elkhartlake/pmutil.c b/src/soc/intel/elkhartlake/pmutil.c index 4d5c04d02d..b969ba5200 100644 --- a/src/soc/intel/elkhartlake/pmutil.c +++ b/src/soc/intel/elkhartlake/pmutil.c @@ -7,7 +7,7 @@ #define __SIMPLE_DEVICE__ -#include +#include #include #include #include @@ -180,12 +180,10 @@ static int rtc_failed(uint32_t gen_pmcon_b) int soc_get_rtc_failed(void) { - const struct chipset_power_state *ps = cbmem_find(CBMEM_ID_POWER_STATE); + const struct chipset_power_state *ps; - if (!ps) { - printk(BIOS_ERR, "Could not find power state in cbmem, RTC init aborted\n"); + if (acpi_pm_state_for_rtc(&ps) < 0) return 1; - } return rtc_failed(ps->gen_pmcon_b); } -- cgit v1.2.3