From 546923f906308a737d7797cb96f183a121ab4e10 Mon Sep 17 00:00:00 2001 From: Julien Viard de Galbert Date: Mon, 5 Mar 2018 11:10:16 +0100 Subject: soc/intel/denverton_ns: Update UART legacy mode to keep FSP traces The FSP can only output its traces when the HSUART PCI device is available. - Move the hiding to after last FSP call. - Adapt coreboot PCI enumeration to keep the legacy configuration. With UART configured as legacy Linux will not re-enumerate it but detects it as legacy (ttyS0 instead of ttyS4). Change-Id: Id8801e178ffd8eeee78ece07da7bd6b8dbd88538 Signed-off-by: Julien Viard de Galbert Reviewed-on: https://review.coreboot.org/23623 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Nico Huber --- src/soc/intel/denverton_ns/bootblock/uart.c | 9 --------- 1 file changed, 9 deletions(-) (limited to 'src/soc/intel/denverton_ns/bootblock') diff --git a/src/soc/intel/denverton_ns/bootblock/uart.c b/src/soc/intel/denverton_ns/bootblock/uart.c index affddbaec2..9af42ee217 100644 --- a/src/soc/intel/denverton_ns/bootblock/uart.c +++ b/src/soc/intel/denverton_ns/bootblock/uart.c @@ -65,15 +65,6 @@ static void pci_early_hsuart_device_probe(u8 bus, u8 dev, u8 func, SIZE_OF_HSUART_RES * func + PSR_OFFSET); *psr_reg >>= 1; #endif - -#if (IS_ENABLED(CONFIG_LEGACY_UART_MODE)) - /* Hide HSUART on PCI to prevent re-enumeration - * and enable legacy mode. - */ - pci_write_config32(uart_dev, PCI_FUNC_RDCFG_HIDE, - pci_read_config32(uart_dev, PCI_FUNC_RDCFG_HIDE) | - 1); -#endif } static void early_config_gpio(void) -- cgit v1.2.3