From e16c9df4542a40c176225e9db034e750eb957d5d Mon Sep 17 00:00:00 2001 From: Kyösti Mälkki Date: Sat, 29 Dec 2018 08:04:16 +0200 Subject: soc/intel: Fix bad uses of __SIMPLE_DEVICE__ MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cases of *dev = PCI_DEV(b,d,f) are invalid. Not caught because files only build with __SIMPLE_DEVICE__ defined. Remove cases of testing __SIMPLE_DEVICE__ in files that are not build for ramstage. Change-Id: If10a0efa187c9b1d9a5577008aa46f050f0aa309 Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/30497 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/soc/intel/denverton_ns/bootblock/uart.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/soc/intel/denverton_ns/bootblock/uart.c') diff --git a/src/soc/intel/denverton_ns/bootblock/uart.c b/src/soc/intel/denverton_ns/bootblock/uart.c index 7d97661bfb..8af6b3928b 100644 --- a/src/soc/intel/denverton_ns/bootblock/uart.c +++ b/src/soc/intel/denverton_ns/bootblock/uart.c @@ -31,11 +31,7 @@ static void pci_early_hsuart_device_probe(u8 bus, u8 dev, u8 func, u32 mmio_base) { register uint16_t reg16; -#if defined(__SIMPLE_DEVICE__) pci_devfn_t uart_dev = PCI_DEV(bus, dev, func); -#else - struct device *uart_dev = PCI_DEV(bus, dev, func); -#endif /* We're using MMIO for HSUARTs. This section is needed for logging * from FSP only -- cgit v1.2.3