From cbc5d3f34b87db779829eabc90c32780a3865a56 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Tue, 25 Apr 2023 15:48:46 +0200 Subject: soc/intel: Don't report _S1 state when unsupported Since skylake Intel hardware does not support this sleep state. Trying to enter S1 by having the OS enter sleep results in a system hang on at least Alder lake (prodrive/atlas). CONFIG_SOC_INTEL_COMMON_BLOCK_PMC is a good proxy whether devices support 'skylake style' PMC PCI device for ACPI registers. Signed-off-by: Arthur Heymans Change-Id: Ic9e19410696240755e8714db53a0525284f3a2da Reviewed-on: https://review.coreboot.org/c/coreboot/+/74760 Tested-by: build bot (Jenkins) Reviewed-by: Lean Sheng Tan Reviewed-by: Werner Zeh --- src/soc/intel/common/block/pmc/Kconfig | 1 + 1 file changed, 1 insertion(+) (limited to 'src/soc/intel/common/block') diff --git a/src/soc/intel/common/block/pmc/Kconfig b/src/soc/intel/common/block/pmc/Kconfig index effdc12585..181ad81262 100644 --- a/src/soc/intel/common/block/pmc/Kconfig +++ b/src/soc/intel/common/block/pmc/Kconfig @@ -4,6 +4,7 @@ config SOC_INTEL_COMMON_BLOCK_PMC bool select HAVE_POWER_STATE_AFTER_FAILURE select HAVE_POWER_STATE_PREVIOUS_AFTER_FAILURE + select ACPI_S1_NOT_SUPPORTED help Intel Processor common code for Power Management controller(PMC) subsystem -- cgit v1.2.3