From 44348185d97036012353c8d53211c68c2444b36d Mon Sep 17 00:00:00 2001 From: Tim Wawrzynczak Date: Thu, 8 Aug 2019 11:21:51 -0600 Subject: soc/intel/common/smm: Add missing printk statement SMI trap handler was missing a printk statement, which caused Coverity to flag "data &= mask;" as a redundant operation. Change-Id: I71da74e5e08e7d7e6d61c1925db19324efd73f0a Found-by: Coverity CID 1381621 Signed-off-by: Tim Wawrzynczak Reviewed-on: https://review.coreboot.org/c/coreboot/+/34797 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth Reviewed-by: Subrata Banik --- src/soc/intel/common/block/smm/smitraphandler.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/soc/intel/common/block/smm') diff --git a/src/soc/intel/common/block/smm/smitraphandler.c b/src/soc/intel/common/block/smm/smitraphandler.c index bfa984651e..974c4897a8 100644 --- a/src/soc/intel/common/block/smm/smitraphandler.c +++ b/src/soc/intel/common/block/smm/smitraphandler.c @@ -108,6 +108,7 @@ void smihandler_southbridge_monitor( /* Trapped write data */ data = pcr_read32(PID_PSTH, PCR_PSTH_TRPD); data &= mask; + printk(BIOS_DEBUG, " iotrap read data = 0x%08x\n", data); } } -- cgit v1.2.3