From e9665959edeba6ae2d5364c4f7339704b6b6fd42 Mon Sep 17 00:00:00 2001 From: Julius Werner Date: Fri, 21 Jan 2022 17:06:20 -0800 Subject: treewide: Remove "ERROR: "/"WARN: " prefixes from log messages Now that the console system itself will clearly differentiate loglevels, it is no longer necessary to explicitly add "ERROR: " in front of every BIOS_ERR message to help it stand out more (and allow automated tooling to grep for it). Removing all these extra .rodata characters should save us a nice little amount of binary size. This patch was created by running find src/ -type f -exec perl -0777 -pi -e 's/printk\(\s*BIOS_ERR,\s*"ERROR: /printk\(BIOS_ERR, "/gi' '{}' ';' and doing some cursory review/cleanup on the result. Then doing the same thing for BIOS_WARN with 's/printk\(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk\(BIOS_WARNING, "/gi' Signed-off-by: Julius Werner Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/61309 Tested-by: build bot (Jenkins) Reviewed-by: HAOUAS Elyes Reviewed-by: Lance Zhao Reviewed-by: Jason Glenesk --- src/soc/intel/common/block/irq/irq.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'src/soc/intel/common/block/irq') diff --git a/src/soc/intel/common/block/irq/irq.c b/src/soc/intel/common/block/irq/irq.c index 007445116a..8b0642f149 100644 --- a/src/soc/intel/common/block/irq/irq.c +++ b/src/soc/intel/common/block/irq/irq.c @@ -128,7 +128,7 @@ static int pirq_to_irq(enum pirq pirq) static bool assign_pirq(struct pin_info pin_info[PCI_INT_MAX], enum pci_pin pin, enum pirq pirq) { if (pirq < PIRQ_A || pirq > PIRQ_H) { - printk(BIOS_ERR, "ERROR: Invalid pirq constraint %u\n", pirq); + printk(BIOS_ERR, "Invalid pirq constraint %u\n", pirq); return false; } @@ -143,7 +143,7 @@ static bool assign_pin(enum pci_pin pin, unsigned int fn, enum pin_state state, enum pci_pin fn_pin_map[MAX_FNS]) { if (pin < PCI_INT_A || pin > PCI_INT_D) { - printk(BIOS_ERR, "ERROR: Invalid pin constraint %u\n", pin); + printk(BIOS_ERR, "Invalid pin constraint %u\n", pin); return false; } @@ -182,7 +182,7 @@ static bool assign_fixed_pirqs(const struct slot_irq_constraints *constraints, fixed pin */ const enum pci_pin pin = fn_pin_map[i]; if (pin == PCI_INT_NONE) { - printk(BIOS_ERR, "ERROR: Slot %u, pirq %u, no pin for function %zu\n", + printk(BIOS_ERR, "Slot %u, pirq %u, no pin for function %zu\n", constraints->slot, fixed_pirq, i); return false; } @@ -210,7 +210,7 @@ static bool assign_direct_irqs(const struct slot_irq_constraints *constraints, const int irq = find_free_unique_irq(); if (irq == INVALID_IRQ) { - printk(BIOS_ERR, "ERROR: No free unique IRQs found\n"); + printk(BIOS_ERR, "No free unique IRQs found\n"); return false; } @@ -234,7 +234,7 @@ static bool assign_shareable_pins(const struct slot_irq_constraints *constraints pin = find_shareable_pin(pin_info); if (pin == PCI_INT_NONE) { - printk(BIOS_ERR, "ERROR: No shareable pins found\n"); + printk(BIOS_ERR, "No shareable pins found\n"); return false; } } -- cgit v1.2.3