From 576861994ea5011c3a836a826b8189ef79c366cb Mon Sep 17 00:00:00 2001 From: Nico Huber Date: Sat, 6 Aug 2022 19:11:55 +0200 Subject: soc/intel/skylake: Assign device ops in chipset devicetree Some PCI IDs were missing, and at least one (SPT's fast SPI device in a generic SPI driver) was wrong. Hence, this patch actually changes behavior depending on the devices actually present in a machine. In this patch the Skylake devicetree is written in a single-line style. Alternative, the device operations could be put on a separate line, e.g. device pci 00.0 alias system_agent on ops systemagent_ops end Tested on Kontron/bSL6. Notable in the log diff is that the CSE and SATA drivers are hooked up now. Change-Id: I8635fc53ca617b029d6fe1845eaef6c5c749db82 Signed-off-by: Nico Huber Reviewed-on: https://review.coreboot.org/c/coreboot/+/66485 Tested-by: build bot (Jenkins) Reviewed-by: Arthur Heymans --- src/soc/intel/common/block/hda/hda.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'src/soc/intel/common/block/hda/hda.c') diff --git a/src/soc/intel/common/block/hda/hda.c b/src/soc/intel/common/block/hda/hda.c index fd0ab4abd5..ac938eadc7 100644 --- a/src/soc/intel/common/block/hda/hda.c +++ b/src/soc/intel/common/block/hda/hda.c @@ -11,7 +11,7 @@ static void hda_init(struct device *dev) azalia_audio_init(dev); } -static struct device_operations hda_ops = { +struct device_operations hda_ops = { .read_resources = pci_dev_read_resources, .set_resources = pci_dev_set_resources, .enable_resources = pci_dev_enable_resources, @@ -32,11 +32,8 @@ static const unsigned short pci_device_ids[] = { PCI_DID_INTEL_RPP_P_AUDIO, PCI_DID_INTEL_APL_AUDIO, PCI_DID_INTEL_GLK_AUDIO, - PCI_DID_INTEL_SKL_AUDIO, - PCI_DID_INTEL_SKL_H_AUDIO, PCI_DID_INTEL_LWB_AUDIO, PCI_DID_INTEL_LWB_AUDIO_SUPER, - PCI_DID_INTEL_KBL_AUDIO, PCI_DID_INTEL_CNL_AUDIO, PCI_DID_INTEL_CNP_H_AUDIO, PCI_DID_INTEL_ICL_AUDIO, -- cgit v1.2.3