From d94cff6ab26d482554309041a9317cc3bf5e4b02 Mon Sep 17 00:00:00 2001 From: Lee Leahy Date: Thu, 16 Mar 2017 17:49:42 -0700 Subject: soc/intel/braswell: Fix most of the issues detected by checkpatch Fix the following errors and warnings detected by checkpatch.pl: ERROR: that open brace { should be on the previous line ERROR: return is not a function, parentheses are not required WARNING: braces {} are not necessary for any arm of this statement WARNING: line over 80 characters WARNING: braces {} are not necessary for single statement blocks WARNING: Avoid unnecessary line continuations WARNING: break is not useful after a goto or return WARNING: else is not generally useful after a break or return False positives are generated by checkpatch for the following test: ERROR: Macros with complex values should be enclosed in parentheses TEST=Build for cyan Change-Id: I19048895145b138a63100b29f829ff446ff71b58 Signed-off-by: Lee Leahy Reviewed-on: https://review.coreboot.org/18871 Reviewed-by: Duncan Laurie Tested-by: build bot (Jenkins) --- src/soc/intel/braswell/southcluster.c | 1 - 1 file changed, 1 deletion(-) (limited to 'src/soc/intel/braswell/southcluster.c') diff --git a/src/soc/intel/braswell/southcluster.c b/src/soc/intel/braswell/southcluster.c index 4e4d157714..1c450e98b0 100644 --- a/src/soc/intel/braswell/southcluster.c +++ b/src/soc/intel/braswell/southcluster.c @@ -390,7 +390,6 @@ static int place_device_in_d3hot(device_t dev) DEV_CASE(TXE) : /* TXE cannot be placed in D3Hot. */ return 0; - break; DEV_CASE(PCIE_PORT1) : DEV_CASE(PCIE_PORT2) : DEV_CASE(PCIE_PORT3) : -- cgit v1.2.3