From e4c30044f2773094f77106dc85940c7ba23ac0af Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Mon, 12 Dec 2022 00:46:05 +0100 Subject: soc/intel/acpi: Replace Add(a,b,c) with ASL 2.0 syntax Replace `Add (a, b, c)` with `c = a + b`, respectively `a += b` where possible. Change-Id: I96390f565d6c1ca0f4e06db9ad07af784051650c Signed-off-by: Felix Singer Reviewed-on: https://review.coreboot.org/c/coreboot/+/70622 Reviewed-by: Eric Lai Tested-by: build bot (Jenkins) Reviewed-by: Elyes Haouas --- src/soc/intel/baytrail/acpi/dptf/dptf.asl | 2 +- src/soc/intel/baytrail/acpi/gpio.asl | 6 +++--- src/soc/intel/baytrail/acpi/southcluster.asl | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src/soc/intel/baytrail/acpi') diff --git a/src/soc/intel/baytrail/acpi/dptf/dptf.asl b/src/soc/intel/baytrail/acpi/dptf/dptf.asl index fd7fc51456..b8b05f78bb 100644 --- a/src/soc/intel/baytrail/acpi/dptf/dptf.asl +++ b/src/soc/intel/baytrail/acpi/dptf/dptf.asl @@ -63,7 +63,7 @@ Device (DPTF) Multiply (Arg0, 10, Local0) /* Convert to Kelvin */ - Add (Local0, 2732, Local0) + Local0 += 2732 Return (Local0) } diff --git a/src/soc/intel/baytrail/acpi/gpio.asl b/src/soc/intel/baytrail/acpi/gpio.asl index 4e48cc6d97..e6dc536cb8 100644 --- a/src/soc/intel/baytrail/acpi/gpio.asl +++ b/src/soc/intel/baytrail/acpi/gpio.asl @@ -22,7 +22,7 @@ Device (GPSC) Method (_CRS) { CreateDwordField (^RBUF, ^RMEM._BAS, RBAS) - Add (IO_BASE_ADDRESS, IO_BASE_OFFSET_GPSCORE, RBAS) + RBAS = IO_BASE_ADDRESS + IO_BASE_OFFSET_GPSCORE Return (^RBUF) } @@ -51,7 +51,7 @@ Device (GPNC) Method (_CRS) { CreateDwordField (^RBUF, ^RMEM._BAS, RBAS) - Add (IO_BASE_ADDRESS, IO_BASE_OFFSET_GPNCORE, RBAS) + RBAS = IO_BASE_ADDRESS + IO_BASE_OFFSET_GPNCORE Return (^RBUF) } @@ -80,7 +80,7 @@ Device (GPSS) Method (_CRS) { CreateDwordField (^RBUF, ^RMEM._BAS, RBAS) - Add (IO_BASE_ADDRESS, IO_BASE_OFFSET_GPSSUS, RBAS) + RBAS = IO_BASE_ADDRESS + IO_BASE_OFFSET_GPSSUS Return (^RBUF) } diff --git a/src/soc/intel/baytrail/acpi/southcluster.asl b/src/soc/intel/baytrail/acpi/southcluster.asl index 94548a35db..3e4f8e2a15 100644 --- a/src/soc/intel/baytrail/acpi/southcluster.asl +++ b/src/soc/intel/baytrail/acpi/southcluster.asl @@ -176,7 +176,7 @@ Method (_CRS, 0, Serialized) /* TOLM is BMBOUND accessible from IOSF so is saved in NVS */ Store (\TOLM, PMIN) Store (Subtract(CONFIG_ECAM_MMCONF_BASE_ADDRESS, 1), PMAX) - Add (Subtract (PMAX, PMIN), 1, PLEN) + PLEN = Subtract (PMAX, PMIN) + 1 Return (MCRS) } -- cgit v1.2.3