From 6d569163ab680ca436b16c040e6840e969df6c61 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Wed, 10 Apr 2019 12:19:27 +0530 Subject: soc/intel/cpulib: Remove redundent enable/disable functions This patch removes multiple enable/disable function definitions and make use of single function with argument to know feature status (enable/disable). Change-Id: I502cd2497b07e9de062df453ecbb9c11df692f5a Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/32282 Reviewed-by: Arthur Heymans Reviewed-by: Lijian Zhao Reviewed-by: Duncan Laurie Tested-by: build bot (Jenkins) --- src/soc/intel/apollolake/cpu.c | 6 ++++-- src/soc/intel/apollolake/romstage.c | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) (limited to 'src/soc/intel/apollolake') diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c index 8f1d933a0b..11d15e4f13 100644 --- a/src/soc/intel/apollolake/cpu.c +++ b/src/soc/intel/apollolake/cpu.c @@ -94,10 +94,12 @@ void soc_core_init(struct device *cpu) /* Set Max Non-Turbo ratio if RAPL is disabled. */ if (CONFIG(APL_SKIP_SET_POWER_LIMITS)) { cpu_set_p_state_to_max_non_turbo_ratio(); - cpu_disable_eist(); + /* Disable speed step */ + cpu_set_eist(false); } else if (CONFIG(APL_SET_MIN_CLOCK_RATIO)) { cpu_set_p_state_to_min_clock_ratio(); - cpu_disable_eist(); + /* Disable speed step */ + cpu_set_eist(false); } } diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index 47fbc0db60..c976ac2d6f 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -197,10 +197,10 @@ void set_max_freq(void) } /* Enable burst mode */ - cpu_enable_burst_mode(); + cpu_burst_mode(true); /* Enable speed step. */ - cpu_enable_eist(); + cpu_set_eist(true); /* Set P-State ratio */ cpu_set_p_state_to_turbo_ratio(); -- cgit v1.2.3