From 58810c7af5f80ef0c58a7aa77a4c20cfcc7d5474 Mon Sep 17 00:00:00 2001 From: Hannah Williams Date: Wed, 2 Aug 2017 18:13:33 -0700 Subject: soc/intel/apollolake: Add file path check Fixes Coverity Issue: 1372243 Change-Id: Ib7e43b195357c723e1ae51f609a8b07ad984380a Signed-off-by: Hannah Williams Reviewed-on: https://review.coreboot.org/20867 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/soc/intel/apollolake/cse.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/soc/intel/apollolake') diff --git a/src/soc/intel/apollolake/cse.c b/src/soc/intel/apollolake/cse.c index 515d32b99c..3e1792c84a 100644 --- a/src/soc/intel/apollolake/cse.c +++ b/src/soc/intel/apollolake/cse.c @@ -92,6 +92,10 @@ static int read_cse_file(const char *path, void *buff, size_t *size, return 0; } + if (strnlen(path, sizeof(msg.file_name)) >= sizeof(msg.file_name)) { + printk(BIOS_ERR, "path too big for msg.file_name buffer\n"); + return 0; + } strncpy(msg.file_name, path, sizeof(msg.file_name)); msg.mkhi_hdr.fields.group_id = MKHI_GROUP_ID_MCA; msg.mkhi_hdr.fields.command = READ_FILE; -- cgit v1.2.3