From 1177bf516540b62e54cefdf346bb6e8a7c376642 Mon Sep 17 00:00:00 2001 From: Hannah Williams Date: Wed, 13 Dec 2017 12:44:26 -0800 Subject: soc/intel/common/block/pmc: Fix ACPI BAR and PCI_COMMAND in PMC config space read_resources in common/block/pmc/pmc.c is corrupting the BAR at offset 0x20. pch_pmc_read_resources | pci_dev_read_resources | pci_get_resource Within pci_get_resource, the BAR is read and written back. Since read of ACPI BAR does not return the correct value, the subsequent write corrupts the BAR. Hence re-programming the BAR. Also, reading PMC STATUSCOMMAND register does not return bit 0 correctly in pci_dev_enable_resources. This causes IO SPACE ACCESS to get disabled. Hence making sure IO ACCESS gets enabled by setting dev->command TEST=Can boot to OS Without this change coreboot will be stuck at "Disabling ACPI via APMC:" Change-Id: I27062419d06127951ecbbb641835d06ca39ff435 Signed-off-by: Hannah Williams Reviewed-on: https://review.coreboot.org/23230 Reviewed-by: Subrata Banik Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/soc/intel/apollolake/Kconfig | 1 + 1 file changed, 1 insertion(+) (limited to 'src/soc/intel/apollolake') diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index b7f2dc92c4..a9f49dbbfd 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -57,6 +57,7 @@ config CPU_SPECIFIC_OPTIONS select PCIEX_LENGTH_256MB select POSTCAR_CONSOLE select POSTCAR_STAGE + select PMC_INVALID_READ_AFTER_WRITE select REG_SCRIPT select RELOCATABLE_RAMSTAGE # Build fails if this is not selected select RTC -- cgit v1.2.3