From 33fd66b46309b140ed9b228083a55a394117afea Mon Sep 17 00:00:00 2001 From: Andrey Petrov Date: Wed, 22 Jun 2016 18:58:14 -0700 Subject: soc/intel/apollolake: Move PMC BAR setup to bootblock Some features of PMC needs to be accessed before romstage. Hence, move PMC BARs setup into bootblock. BUG=chrome-os-partner:54149 BRANCH=none TEST=none Change-Id: I14493498314ef1a4ce383e192edccf65fed2d2cb Signed-off-by: Andrey Petrov Reviewed-on: https://review.coreboot.org/15332 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- src/soc/intel/apollolake/romstage.c | 14 -------------- 1 file changed, 14 deletions(-) (limited to 'src/soc/intel/apollolake/romstage.c') diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index 0c8f1c2de7..ce28326392 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -65,28 +65,14 @@ static struct chipset_power_state power_state CAR_GLOBAL; /* * Enables several BARs and devices which are needed for memory init * - MCH_BASE_ADDR is needed in order to talk to the memory controller - * - PMC_BAR0 and PMC_BAR1 are used by FSP (with the base address hardcoded) - * Once raminit is done, we can safely let the allocator re-assign them * - HPET is enabled because FSP wants to store a pointer to global data in the * HPET comparator register */ static void soc_early_romstage_init(void) { - device_t pmc = PMC_DEV; - /* Set MCH base address and enable bit */ pci_write_config32(NB_DEV_ROOT, MCHBAR, MCH_BASE_ADDR | 1); - /* Set PMC base addresses and enable decoding. */ - pci_write_config32(pmc, PCI_BASE_ADDRESS_0, PMC_BAR0); - pci_write_config32(pmc, PCI_BASE_ADDRESS_1, 0); /* 64-bit BAR */ - pci_write_config32(pmc, PCI_BASE_ADDRESS_2, PMC_BAR1); - pci_write_config32(pmc, PCI_BASE_ADDRESS_3, 0); /* 64-bit BAR */ - pci_write_config16(pmc, PCI_BASE_ADDRESS_4, ACPI_PMIO_BASE); - pci_write_config16(pmc, PCI_COMMAND, - PCI_COMMAND_IO | PCI_COMMAND_MEMORY | - PCI_COMMAND_MASTER); - /* Enable decoding for HPET. Needed for FSP global pointer storage */ pci_write_config8(P2SB_DEV, P2SB_HPTC, P2SB_HPTC_ADDRESS_SELECT_0 | P2SB_HPTC_ADDRESS_ENABLE); -- cgit v1.2.3