From 9e9cf270c4cbef24fb5127056b2eef4106d358ea Mon Sep 17 00:00:00 2001 From: Mario Scheithauer Date: Mon, 15 May 2017 17:24:56 +0200 Subject: soc/intel/apollolake: Enable decoding for ComA and ComB on LPC If there is an external 8250 UART, one needs to enable the appropriate address ranges before console_init() is called so that the init sequence can reach the external UART. Furthermore FSPM needs different settings for an external UART port. For this, the function fill_console_params() has to be adapted. Change-Id: I62c7d0b54edd18acf793849aef352afbcaeb68b9 Signed-off-by: Mario Scheithauer Reviewed-on: https://review.coreboot.org/19693 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh Reviewed-by: Aaron Durbin --- src/soc/intel/apollolake/include/soc/lpc.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/soc/intel/apollolake/include') diff --git a/src/soc/intel/apollolake/include/soc/lpc.h b/src/soc/intel/apollolake/include/soc/lpc.h index 7e3d74aaf6..da918a16b4 100644 --- a/src/soc/intel/apollolake/include/soc/lpc.h +++ b/src/soc/intel/apollolake/include/soc/lpc.h @@ -29,8 +29,11 @@ * IO decode enable macros are in the format IO__. * For example, to open ports 0x60, 0x64 for the keyboard controller, * use IOE_KBC_60_64 macro. For IOE_ macros that do not specify a port range, - * the port range is selectable via the IO decodes register (not referenced). + * the port range is selectable via the IO decodes register. */ +#define REG_IO_DECODE 0x80 +#define IOD_COMA_RANGE (0 << 0) /* 0x3F8 - 0x3FF COMA*/ +#define IOD_COMB_RANGE (1 << 4) /* 0x2F8 - 0x2FF COMB*/ #define REG_IO_ENABLES 0x82 #define IOE_EC_4E_4F (1 << 13) #define IOE_SUPERIO_2E_2F (1 << 12) -- cgit v1.2.3