From 77cc3267fc970c710299a164ecbc471f9287d719 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Sat, 19 Sep 2020 13:20:58 +0530 Subject: soc/intel: Refactor do_global_reset() function List of changes: 1. Rename do_global_reset() to force_global_reset() 2. Make force_global_reset() function static 3. Implement force_global_reset() into common/reset.c to avoid dedicated SoC implementation 4. Remove redundant force_global_reset() implementation from dedicated SoC 5. Make direct call to global_reset() from cse_lite.c 7. Drop CONFIG_HAVE_CF9_RESET_PREPARE Kconfig from APL SoC due to common reset (soc/intel/common/reset.c) code migration 8. Remove unused function send_global_reset() from SKL me.c due to common reset code migration 9. Delete heci.c from APL SoC as unused Signed-off-by: Subrata Banik Change-Id: I1c5dc8d5606ef28ffaed4a64d90f470ae1ffc2a6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/45541 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh --- src/soc/intel/apollolake/heci.c | 22 ---------------------- 1 file changed, 22 deletions(-) delete mode 100644 src/soc/intel/apollolake/heci.c (limited to 'src/soc/intel/apollolake/heci.c') diff --git a/src/soc/intel/apollolake/heci.c b/src/soc/intel/apollolake/heci.c deleted file mode 100644 index 52dcca8de2..0000000000 --- a/src/soc/intel/apollolake/heci.c +++ /dev/null @@ -1,22 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-or-later */ - -#include -#include -#include -#include -#include - -uint32_t heci_fw_sts(void) -{ - return pci_read_config32(PCH_DEV_CSE, REG_SEC_FW_STS0); -} - -bool heci_cse_normal(void) -{ - return ((heci_fw_sts() & MASK_SEC_STATUS) == SEC_STATE_NORMAL); -} - -bool heci_cse_done(void) -{ - return (!!(heci_fw_sts() & MASK_SEC_FIRMWARE_COMPLETE)); -} -- cgit v1.2.3