From 9cd6a265e2af9629a5391212ccf6e4ddf1c9ebd8 Mon Sep 17 00:00:00 2001 From: Pratik Prajapati Date: Mon, 14 Aug 2017 13:57:46 -0700 Subject: intel/common/mp_init: Refactor MP Init code to get rid of microcode param Remove passing microcode patch pointer as param while calling - soc_core_init() - soc_init_cpus() Also change callbacks in apollolake/geminilake and skylake/kabylake common code to reflect the same function signature. Change-Id: Ib03bb4a3063d243d97b132e0dc288ef3868a5a7b Signed-off-by: Pratik Prajapati Reviewed-on: https://review.coreboot.org/21010 Reviewed-by: Aaron Durbin Tested-by: build bot (Jenkins) --- src/soc/intel/apollolake/cpu.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'src/soc/intel/apollolake/cpu.c') diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c index f81c2eef8d..98cd23ade4 100644 --- a/src/soc/intel/apollolake/cpu.c +++ b/src/soc/intel/apollolake/cpu.c @@ -60,7 +60,7 @@ static const struct reg_script core_msr_script[] = { REG_SCRIPT_END }; -void soc_core_init(device_t cpu, const void *microcode) +void soc_core_init(device_t cpu) { /* Set core MSRs */ reg_script_run(core_msr_script); @@ -75,7 +75,7 @@ void soc_core_init(device_t cpu, const void *microcode) #if !IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT) static void soc_init_core(device_t cpu) { - soc_core_init(cpu, NULL); + soc_core_init(cpu); } static struct device_operations cpu_dev_ops = { @@ -223,7 +223,7 @@ static const struct mp_ops mp_ops = { .post_mp_init = smm_southbridge_enable, }; -void soc_init_cpus(struct bus *cpu_bus, const void *microcode) +void soc_init_cpus(struct bus *cpu_bus) { /* Clear for take-off */ if (mp_init_with_smm(cpu_bus, &mp_ops)) @@ -234,7 +234,7 @@ void apollolake_init_cpus(struct device *dev) { if (IS_ENABLED(CONFIG_SOC_INTEL_COMMON_BLOCK_CPU_MPINIT)) return; - soc_init_cpus(dev->link_list, NULL); + soc_init_cpus(dev->link_list); /* Temporarily cache the memory-mapped boot media. */ if (IS_ENABLED(CONFIG_BOOT_DEVICE_MEMORY_MAPPED) && -- cgit v1.2.3