From fc4c7d8320d329d3712cb74e527dca4178f71bf8 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Fri, 3 Mar 2017 18:23:59 +0530 Subject: soc/intel/apollolake: Clean up code by using common CAR init This patch currently contains common CAR initialization required in bootblock phase along with common MSR header - 1. Use SOC_INTEL_COMMON_BLOCK_CAR to have common CAR initialization and CAR teardown. 2. Use common MSR header "intelblocks/msr.h" inside soc/cpu.h Change-Id: I67f909f50a24f009b3e35388665251be1dde40f7 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/18555 Tested-by: build bot (Jenkins) Reviewed-by: Martin Roth --- src/soc/intel/apollolake/Kconfig | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to 'src/soc/intel/apollolake/Kconfig') diff --git a/src/soc/intel/apollolake/Kconfig b/src/soc/intel/apollolake/Kconfig index 45ee5c98ff..5087fa6033 100644 --- a/src/soc/intel/apollolake/Kconfig +++ b/src/soc/intel/apollolake/Kconfig @@ -50,6 +50,7 @@ config CPU_SPECIFIC_OPTIONS select SOC_INTEL_COMMON select SOC_INTEL_COMMON_ACPI select SOC_INTEL_COMMON_ACPI_WAKE_SOURCE + select SOC_INTEL_COMMON_BLOCK select SOC_INTEL_COMMON_LPSS_I2C select SOC_INTEL_COMMON_SMI select SOC_INTEL_COMMON_SPI_FLASH_PROTECT @@ -253,6 +254,7 @@ config NHLT_DA7219 default n help Include DSP firmware settings for headset codec. + choice prompt "Cache-as-ram implementation" default CAR_CQOS @@ -261,6 +263,8 @@ choice config CAR_NEM bool "Non-evict mode" + select SOC_INTEL_COMMON_BLOCK_CAR + select INTEL_CAR_NEM help Traditionally, CAR is set up by using Non-Evict mode. This method does not allow CAR and cache to co-exist, because cache fills are @@ -268,11 +272,19 @@ config CAR_NEM config CAR_CQOS bool "Cache Quality of Service" + select SOC_INTEL_COMMON_BLOCK_CAR + select INTEL_CAR_CQOS help Cache Quality of Service allows more fine-grained control of cache usage. As result, it is possible to set up portion of L2 cache for CAR and use remainder for actual caching. +config USE_APOLLOLAKE_FSP_CAR + bool "Use FSP CAR" + select FSP_CAR + help + Use FSP APIs to initialize & tear Down the Cache-As-Ram. + endchoice # -- cgit v1.2.3