From 23ef60de984bb67e90cc08edb2852d989d47c616 Mon Sep 17 00:00:00 2001 From: Kapil Porwal Date: Mon, 16 Jan 2023 16:07:48 +0000 Subject: intel/alderlake: remove skip_mbp_hob SOC chip config Introduce at new config option CONFIG_FSP_PUBLISH_MBP_HOB to control the creation of ME_BIOS_PAYLOAD_HOB (MBP HOB) by FSP. This new option is hooked with `SkipMbpHob` UPD and is always disabled for RPL & ADL-N based ChromeOS platforms. It is not disabled for ADL-P based platforms because ADL-P FSP relies on MBP HOB for ChipsetInit version for ChipsetInit sync. As ChipsetInit sync doesn't occur if no MBP HOB, so it results S0ix issue. This limitation is addressed in the later platforms so creation of MBP HOB can be skipped for ADL-N and RPL based platforms. This made skip_mbp_hob SOC chip config variable redundant which is also removed as part of this change. BUG=none TEST=Build and boot to Google/Taniks. Signed-off-by: Kapil Porwal Change-Id: Ia396b633a71aedf592c45b69063ee0528840fd2b Reviewed-on: https://review.coreboot.org/c/coreboot/+/71996 Tested-by: build bot (Jenkins) Reviewed-by: Subrata Banik --- src/soc/intel/alderlake/Kconfig | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'src/soc/intel/alderlake/Kconfig') diff --git a/src/soc/intel/alderlake/Kconfig b/src/soc/intel/alderlake/Kconfig index 9c5868b0d6..afa2a752df 100644 --- a/src/soc/intel/alderlake/Kconfig +++ b/src/soc/intel/alderlake/Kconfig @@ -537,4 +537,18 @@ config INTEL_GMA_BCLM_OFFSET config INTEL_GMA_BCLM_WIDTH default 32 +config FSP_PUBLISH_MBP_HOB + bool + default n if CHROMEOS && (SOC_INTEL_RAPTORLAKE || SOC_INTEL_ALDERLAKE_PCH_N) + default y + help + This is to control creation of ME_BIOS_PAYLOAD_HOB (MBP HOB) by FSP. + Disabling it for the platforms, which do not use MBP HOB, can improve the boot time. + + Note: It cannot be disabled for ADL-P based platforms because ADL-P FSP relies on + MBP HOB for ChipsetInit version for ChipsetInit sync. As ChipsetInit sync doesn't + occur if no MBP HOB, so it results S0ix issue. This limitation is addressed in the + later platforms so creation of MBP HOB can be skipped for ADL-N and RPL based + platforms. + endif -- cgit v1.2.3