From f80e6d6f567b8f47e32b3f54b846802825510bf9 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 30 Jul 2021 03:26:15 +0200 Subject: soc/amd/common/block/gpio_banks: use unsigned int for gevent parameter A valid GEVENT number is never negative. The local variable in set_single_gpio still needs to be a signed integer, since the return value of get_gpio_gevent being -1 indicates that the GPIO can't generate a GEVENT. The check for that makes the function return before calling program_smi of program_sci, so the parameter of those functions can be changed to unsigned. Signed-off-by: Felix Held Change-Id: I6ce23ceed1585589932824b8cab2a138328672a9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/56705 Reviewed-by: Marshall Dawson Tested-by: build bot (Jenkins) --- src/soc/amd/common/block/gpio_banks/gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/soc/amd') diff --git a/src/soc/amd/common/block/gpio_banks/gpio.c b/src/soc/amd/common/block/gpio_banks/gpio.c index 8cfca8b216..8f84cb67fc 100644 --- a/src/soc/amd/common/block/gpio_banks/gpio.c +++ b/src/soc/amd/common/block/gpio_banks/gpio.c @@ -27,7 +27,7 @@ static int get_gpio_gevent(gpio_t gpio, const struct soc_amd_event *table, return -1; } -static void program_smi(uint32_t flags, int gevent_num) +static void program_smi(uint32_t flags, unsigned int gevent_num) { uint8_t level; @@ -52,7 +52,7 @@ static void program_smi(uint32_t flags, int gevent_num) * In a similar fashion, polarity (rising/falling, hi/lo) of each GPE is * represented as a single bit in SMI_SCI_TRIG register. */ -static void program_sci(uint32_t flags, int gevent_num) +static void program_sci(uint32_t flags, unsigned int gevent_num) { struct sci_source sci; -- cgit v1.2.3