From 4f886cc19a7e348bf4b996ec50890901ffbc49eb Mon Sep 17 00:00:00 2001 From: Marc Jones Date: Wed, 11 Oct 2017 20:20:49 -0600 Subject: amd/stoneyridge: Make all AGESA reset requests immediate The AGESA RESET_WHENEVER request were never doing a reset in coreboot. We don't have a way to collect a whenever and reset at some later time, so just do the reset immediately. BUG=b:64719937 BRANCH=none TEST=Check AGESA reset request in booblock does a reset in the serial console or ec console. Change-Id: If2654ec0c5c5dbdcea6fc9374371c3388d29fdc7 Signed-off-by: Marc Jones Reviewed-on: https://review.coreboot.org/21978 Reviewed-by: Martin Roth Tested-by: build bot (Jenkins) --- src/soc/amd/common/def_callouts.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'src/soc/amd') diff --git a/src/soc/amd/common/def_callouts.c b/src/soc/amd/common/def_callouts.c index 4b71d5b105..fe0d5497e1 100644 --- a/src/soc/amd/common/def_callouts.c +++ b/src/soc/amd/common/def_callouts.c @@ -67,17 +67,14 @@ AGESA_STATUS agesa_Reset(UINT32 Func, UINTN Data, VOID *ConfigPtr) ResetType = Data; StdHeader = ConfigPtr; - /* Perform the RESET based upon the ResetType. In case of - * WARM_RESET_WHENEVER and COLD_RESET_WHENEVER, the request will go to - * AmdResetManager. During the critical condition, where reset is - * required immediately, the reset will be invoked directly by writing - * 0x04 to port 0xCF9 (Reset Port). + /* + * This should perform the RESET based upon the ResetType, but coreboot + * doesn't have a reset manager to handle a WHENEVER case. Do all + * resets immediately. */ switch (ResetType) { case WARM_RESET_WHENEVER: case COLD_RESET_WHENEVER: - break; - case WARM_RESET_IMMEDIATELY: case COLD_RESET_IMMEDIATELY: Value = 0x06; -- cgit v1.2.3