From 0d98cc48446f355212a5a4a6e92c72b7458032d8 Mon Sep 17 00:00:00 2001 From: Fred Reitberger Date: Tue, 18 Oct 2022 14:33:51 -0400 Subject: soc/amd/morgana/i2c: Remove to-do after review Reviewed files and values match morgana ppr #57396, rev 1.52 Signed-off-by: Fred Reitberger Change-Id: I9d058b0f61b4784a1d83289e75705a6415405d0b Reviewed-on: https://review.coreboot.org/c/coreboot/+/68547 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Felix Held --- src/soc/amd/morgana/i2c.c | 2 -- src/soc/amd/morgana/include/soc/i2c.h | 5 ++--- 2 files changed, 2 insertions(+), 5 deletions(-) (limited to 'src/soc/amd') diff --git a/src/soc/amd/morgana/i2c.c b/src/soc/amd/morgana/i2c.c index 13b3959a77..92dd00daa1 100644 --- a/src/soc/amd/morgana/i2c.c +++ b/src/soc/amd/morgana/i2c.c @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: Update for Morgana */ - #include #include #include diff --git a/src/soc/amd/morgana/include/soc/i2c.h b/src/soc/amd/morgana/include/soc/i2c.h index 900bdca541..89463365e8 100644 --- a/src/soc/amd/morgana/include/soc/i2c.h +++ b/src/soc/amd/morgana/include/soc/i2c.h @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: Update for Morgana */ - #ifndef AMD_MORGANA_I2C_H #define AMD_MORGANA_I2C_H @@ -12,7 +10,8 @@ #define GPIO_I2C1_SCL BIT(1) #define GPIO_I2C2_SCL BIT(2) #define GPIO_I2C3_SCL BIT(3) -#define GPIO_I2C_MASK (BIT(0) | BIT(1) | BIT(2) | BIT(3)) +#define GPIO_I2C_MASK (GPIO_I2C0_SCL | GPIO_I2C1_SCL | \ + GPIO_I2C2_SCL | GPIO_I2C3_SCL) #define I2C0_SCL_PIN GPIO_145 -- cgit v1.2.3