From 396fb3db74db75d2cace0d9942d9b4ed49a7e497 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Fri, 28 Oct 2022 19:25:53 +0200 Subject: soc/amd/*/acpi/mmio.asl,sb_fch.asl: hide AAHB device Don't set bit 2 in _STA in order for Windows not to show a warning about an unknown device in the device manager for this device. Since the _STA object just returns a constant, a name definition can be used instead of a method definition. TEST=The unknown device with device instance path ACPI\AAHB0000\0 disappeared from the device manager in Windows 10 build 19045 on a Mandolin board with a Picasso APU. Just shutting down and then booting it again won't clear some internal state in Windows, so a reboot is needed instead for the change to become visible. Signed-off-by: Felix Held Change-Id: I8cb1712756c3623cc3ea16210af69cde0fa18f62 Reviewed-on: https://review.coreboot.org/c/coreboot/+/68961 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel Reviewed-by: Martin Roth --- src/soc/amd/picasso/acpi/sb_fch.asl | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'src/soc/amd/picasso') diff --git a/src/soc/amd/picasso/acpi/sb_fch.asl b/src/soc/amd/picasso/acpi/sb_fch.asl index 7ab3b17fcb..d58e044882 100644 --- a/src/soc/amd/picasso/acpi/sb_fch.asl +++ b/src/soc/amd/picasso/acpi/sb_fch.asl @@ -14,11 +14,7 @@ Device (AAHB) { Memory32Fixed (ReadWrite, ALINK_AHB_ADDRESS, 0x2000) }) - - Method (_STA, 0x0, NotSerialized) - { - Return (0x0F) - } + Name (_STA, 0xb) } Device (GPIO) -- cgit v1.2.3