From 9c0bce5f28a703aa9f7d777acc3ed35651ce2115 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Wed, 12 Jul 2023 22:58:05 +0200 Subject: soc/amd/phoenix/early_fch: don't call enable_acpimmio_decode_pm04 The enable_acpimmio_decode_pm04 function uses the IO port based indirect access of the PM register space. The PM_INDEX and PM_DATA registers don't exist any more on Phoenix, so the code shouldn't access those. Since the PM_04_ACPIMMIO_DECODE_EN bit in the ACPIMMIO_DECODE_REGISTER_04 register is 1 after reset, the ACPIMMIO space is still accessible. Signed-off-by: Felix Held Change-Id: Ia41f239b023edc094f5cbae63ed7c079649c74da Reviewed-on: https://review.coreboot.org/c/coreboot/+/76437 Reviewed-by: Matt DeVillier Reviewed-by: Karthik Ramasubramanian Tested-by: build bot (Jenkins) --- src/soc/amd/phoenix/early_fch.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) (limited to 'src/soc/amd/phoenix') diff --git a/src/soc/amd/phoenix/early_fch.c b/src/soc/amd/phoenix/early_fch.c index d74ef3e30f..bcfddb2241 100644 --- a/src/soc/amd/phoenix/early_fch.c +++ b/src/soc/amd/phoenix/early_fch.c @@ -19,9 +19,12 @@ /* Before console init */ void fch_pre_init(void) { - /* Enable_acpimmio_decode_pm04 to enable the ACPIMMIO decode which is needed to access - the GPIO registers. */ - enable_acpimmio_decode_pm04(); + /* + * PM_04_ACPIMMIO_DECODE_EN which enables the ACPIMMIO decode is already set after + * reset. Since the IO port based indirect PM register space access isn't implemented + * in Phoenix any more, don't call enable_acpimmio_decode_pm04() which uses the + * indirect PM register space access via the IO ports that aren't implemented any more. + */ /* Setup SPI base by calling lpc_early_init before setting up eSPI. */ lpc_early_init(); -- cgit v1.2.3