From d34dbe5888fb11f2a6bb9bd0e4624d2e2f9f350a Mon Sep 17 00:00:00 2001 From: Grzegorz Bernacki Date: Tue, 25 Apr 2023 15:30:14 +0000 Subject: soc/amd/common/block/cpu: Refactor ucode allocation Move microcode load/unload to pre_mp_init and post_mp_init callbacks. It allows to make sure that ucode is freed only if all APs updated microcode. BUG=b:278264488 TEST=Build and run with additional debug prints added to confirm that data are correctly unmapped Change-Id: I200d24df6157cc6d06bade34809faefea9f0090a Signed-off-by: Grzegorz Bernacki Reviewed-on: https://review.coreboot.org/c/coreboot/+/74777 Tested-by: build bot (Jenkins) Reviewed-by: Karthik Ramasubramanian --- src/soc/amd/phoenix/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/soc/amd/phoenix/cpu.c') diff --git a/src/soc/amd/phoenix/cpu.c b/src/soc/amd/phoenix/cpu.c index 848f667bf1..2c8f77130a 100644 --- a/src/soc/amd/phoenix/cpu.c +++ b/src/soc/amd/phoenix/cpu.c @@ -42,7 +42,7 @@ static void zen_2_3_init(struct device *dev) check_mca(); set_cstate_io_addr(); - amd_update_microcode_from_cbfs(); + amd_apply_microcode_patch(); } static struct device_operations cpu_dev_ops = { -- cgit v1.2.3